-
Notifications
You must be signed in to change notification settings - Fork 293
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tag to specify if the user is setting DD_SERVICE #8318
base: master
Are you sure you want to change the base?
Add tag to specify if the user is setting DD_SERVICE #8318
Conversation
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 53 metrics, 10 unstable metrics. Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.46.0-SNAPSHOT~c68fa9d79a, baseline=1.47.0-SNAPSHOT~b24d15319f
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.04 s) : 0, 1040201
Total [baseline] (10.482 s) : 0, 10481709
Agent [candidate] (1.039 s) : 0, 1039240
Total [candidate] (10.524 s) : 0, 10523753
section appsec
Agent [baseline] (1.182 s) : 0, 1181581
Total [baseline] (10.737 s) : 0, 10736630
Agent [candidate] (1.18 s) : 0, 1179521
Total [candidate] (10.767 s) : 0, 10766565
section iast
Agent [baseline] (1.168 s) : 0, 1167817
Total [baseline] (10.938 s) : 0, 10938133
Agent [candidate] (1.192 s) : 0, 1191760
Total [candidate] (10.997 s) : 0, 10996656
section profiling
Agent [baseline] (1.262 s) : 0, 1261811
Total [baseline] (10.91 s) : 0, 10910387
Agent [candidate] (1.256 s) : 0, 1256117
Total [candidate] (10.847 s) : 0, 10847126
gantt
title petclinic - break down per module: candidate=1.46.0-SNAPSHOT~c68fa9d79a, baseline=1.47.0-SNAPSHOT~b24d15319f
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (715.874 ms) : 0, 715874
BytebuddyAgent [candidate] (715.337 ms) : 0, 715337
GlobalTracer [baseline] (240.372 ms) : 0, 240372
GlobalTracer [candidate] (239.623 ms) : 0, 239623
AppSec [baseline] (55.214 ms) : 0, 55214
AppSec [candidate] (55.462 ms) : 0, 55462
Remote Config [baseline] (711.737 µs) : 0, 712
Remote Config [candidate] (706.73 µs) : 0, 707
Telemetry [baseline] (12.804 ms) : 0, 12804
Telemetry [candidate] (12.87 ms) : 0, 12870
section appsec
BytebuddyAgent [baseline] (732.629 ms) : 0, 732629
BytebuddyAgent [candidate] (731.499 ms) : 0, 731499
GlobalTracer [baseline] (237.863 ms) : 0, 237863
GlobalTracer [candidate] (237.201 ms) : 0, 237201
IAST [baseline] (21.289 ms) : 0, 21289
IAST [candidate] (21.382 ms) : 0, 21382
AppSec [baseline] (176.217 ms) : 0, 176217
AppSec [candidate] (175.981 ms) : 0, 175981
Remote Config [baseline] (655.044 µs) : 0, 655
Remote Config [candidate] (643.025 µs) : 0, 643
Telemetry [baseline] (8.379 ms) : 0, 8379
Telemetry [candidate] (8.265 ms) : 0, 8265
section iast
BytebuddyAgent [baseline] (832.895 ms) : 0, 832895
BytebuddyAgent [candidate] (853.134 ms) : 0, 853134
GlobalTracer [baseline] (231.285 ms) : 0, 231285
GlobalTracer [candidate] (233.15 ms) : 0, 233150
IAST [baseline] (25.542 ms) : 0, 25542
IAST [candidate] (26.094 ms) : 0, 26094
AppSec [baseline] (53.567 ms) : 0, 53567
AppSec [candidate] (54.394 ms) : 0, 54394
Remote Config [baseline] (599.126 µs) : 0, 599
Remote Config [candidate] (621.122 µs) : 0, 621
Telemetry [baseline] (8.606 ms) : 0, 8606
Telemetry [candidate] (8.785 ms) : 0, 8785
section profiling
BytebuddyAgent [baseline] (706.39 ms) : 0, 706390
BytebuddyAgent [candidate] (704.443 ms) : 0, 704443
GlobalTracer [baseline] (350.639 ms) : 0, 350639
GlobalTracer [candidate] (350.544 ms) : 0, 350544
AppSec [baseline] (55.619 ms) : 0, 55619
AppSec [candidate] (54.253 ms) : 0, 54253
Remote Config [baseline] (688.664 µs) : 0, 689
Remote Config [candidate] (687.996 µs) : 0, 688
Telemetry [baseline] (8.985 ms) : 0, 8985
Telemetry [candidate] (8.873 ms) : 0, 8873
ProfilingAgent [baseline] (97.231 ms) : 0, 97231
ProfilingAgent [candidate] (95.186 ms) : 0, 95186
Profiling [baseline] (97.255 ms) : 0, 97255
Profiling [candidate] (95.209 ms) : 0, 95209
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.46.0-SNAPSHOT~c68fa9d79a, baseline=1.47.0-SNAPSHOT~b24d15319f
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.042 s) : 0, 1042291
Total [baseline] (8.692 s) : 0, 8691834
Agent [candidate] (1.04 s) : 0, 1039814
Total [candidate] (8.62 s) : 0, 8620319
section iast
Agent [baseline] (1.175 s) : 0, 1175176
Total [baseline] (9.239 s) : 0, 9238714
Agent [candidate] (1.169 s) : 0, 1168521
Total [candidate] (9.278 s) : 0, 9277675
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.175 s) : 0, 1174765
Total [baseline] (9.251 s) : 0, 9251265
Agent [candidate] (1.175 s) : 0, 1175226
Total [candidate] (9.189 s) : 0, 9188834
section iast_TELEMETRY_OFF
Agent [baseline] (1.176 s) : 0, 1176181
Total [baseline] (9.258 s) : 0, 9258268
Agent [candidate] (1.171 s) : 0, 1171065
Total [candidate] (9.258 s) : 0, 9258331
gantt
title insecure-bank - break down per module: candidate=1.46.0-SNAPSHOT~c68fa9d79a, baseline=1.47.0-SNAPSHOT~b24d15319f
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (716.118 ms) : 0, 716118
BytebuddyAgent [candidate] (715.567 ms) : 0, 715567
GlobalTracer [baseline] (241.759 ms) : 0, 241759
GlobalTracer [candidate] (239.784 ms) : 0, 239784
AppSec [baseline] (55.895 ms) : 0, 55895
AppSec [candidate] (55.556 ms) : 0, 55556
Remote Config [baseline] (726.34 µs) : 0, 726
Remote Config [candidate] (709.922 µs) : 0, 710
Telemetry [baseline] (12.538 ms) : 0, 12538
Telemetry [candidate] (12.983 ms) : 0, 12983
section iast
BytebuddyAgent [baseline] (838.324 ms) : 0, 838324
BytebuddyAgent [candidate] (833.343 ms) : 0, 833343
GlobalTracer [baseline] (231.862 ms) : 0, 231862
GlobalTracer [candidate] (230.964 ms) : 0, 230964
IAST [baseline] (24.307 ms) : 0, 24307
IAST [candidate] (27.108 ms) : 0, 27108
AppSec [baseline] (55.923 ms) : 0, 55923
AppSec [candidate] (52.401 ms) : 0, 52401
Remote Config [baseline] (617.359 µs) : 0, 617
Remote Config [candidate] (616.411 µs) : 0, 616
Telemetry [baseline] (8.795 ms) : 0, 8795
Telemetry [candidate] (8.783 ms) : 0, 8783
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (838.318 ms) : 0, 838318
BytebuddyAgent [candidate] (838.723 ms) : 0, 838723
GlobalTracer [baseline] (231.782 ms) : 0, 231782
GlobalTracer [candidate] (231.164 ms) : 0, 231164
IAST [baseline] (26.019 ms) : 0, 26019
IAST [candidate] (26.856 ms) : 0, 26856
AppSec [baseline] (53.921 ms) : 0, 53921
AppSec [candidate] (53.633 ms) : 0, 53633
Remote Config [baseline] (612.865 µs) : 0, 613
Remote Config [candidate] (623.586 µs) : 0, 624
Telemetry [baseline] (8.727 ms) : 0, 8727
Telemetry [candidate] (8.827 ms) : 0, 8827
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (837.669 ms) : 0, 837669
BytebuddyAgent [candidate] (835.755 ms) : 0, 835755
GlobalTracer [baseline] (233.804 ms) : 0, 233804
GlobalTracer [candidate] (231.27 ms) : 0, 231270
IAST [baseline] (26.423 ms) : 0, 26423
IAST [candidate] (25.144 ms) : 0, 25144
AppSec [baseline] (53.531 ms) : 0, 53531
AppSec [candidate] (54.233 ms) : 0, 54233
Remote Config [baseline] (629.138 µs) : 0, 629
Remote Config [candidate] (616.551 µs) : 0, 617
Telemetry [baseline] (8.758 ms) : 0, 8758
Telemetry [candidate] (8.67 ms) : 0, 8670
LoadParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 13 metrics, 15 unstable metrics. Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.46.0-SNAPSHOT~c68fa9d79a, baseline=1.47.0-SNAPSHOT~b24d15319f
dateFormat X
axisFormat %s
section baseline
no_agent (1.362 ms) : 1342, 1381
. : milestone, 1362,
appsec (1.747 ms) : 1723, 1771
. : milestone, 1747,
appsec_no_iast (1.769 ms) : 1746, 1791
. : milestone, 1769,
iast (1.506 ms) : 1482, 1531
. : milestone, 1506,
profiling (1.518 ms) : 1495, 1541
. : milestone, 1518,
tracing (1.48 ms) : 1457, 1504
. : milestone, 1480,
section candidate
no_agent (1.373 ms) : 1353, 1392
. : milestone, 1373,
appsec (1.748 ms) : 1725, 1772
. : milestone, 1748,
appsec_no_iast (1.766 ms) : 1738, 1794
. : milestone, 1766,
iast (1.528 ms) : 1504, 1552
. : milestone, 1528,
profiling (1.521 ms) : 1497, 1544
. : milestone, 1521,
tracing (1.476 ms) : 1452, 1500
. : milestone, 1476,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.46.0-SNAPSHOT~c68fa9d79a, baseline=1.47.0-SNAPSHOT~b24d15319f
dateFormat X
axisFormat %s
section baseline
no_agent (379.331 µs) : 359, 400
. : milestone, 379,
iast (508.933 µs) : 486, 532
. : milestone, 509,
iast_FULL (741.151 µs) : 719, 763
. : milestone, 741,
iast_GLOBAL (555.093 µs) : 534, 577
. : milestone, 555,
iast_HARDCODED_SECRET_DISABLED (506.55 µs) : 484, 529
. : milestone, 507,
iast_INACTIVE (455.696 µs) : 435, 477
. : milestone, 456,
iast_TELEMETRY_OFF (498.397 µs) : 475, 522
. : milestone, 498,
tracing (457.751 µs) : 436, 479
. : milestone, 458,
section candidate
no_agent (381.702 µs) : 362, 401
. : milestone, 382,
iast (514.51 µs) : 491, 538
. : milestone, 515,
iast_FULL (750.033 µs) : 728, 772
. : milestone, 750,
iast_GLOBAL (560.789 µs) : 537, 584
. : milestone, 561,
iast_HARDCODED_SECRET_DISABLED (506.593 µs) : 484, 530
. : milestone, 507,
iast_INACTIVE (456.283 µs) : 435, 477
. : milestone, 456,
iast_TELEMETRY_OFF (491.417 µs) : 468, 514
. : milestone, 491,
tracing (454.852 µs) : 434, 476
. : milestone, 455,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics. Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.46.0-SNAPSHOT~c68fa9d79a, baseline=1.47.0-SNAPSHOT~b24d15319f
dateFormat X
axisFormat %s
section baseline
no_agent (15.438 s) : 15438000, 15438000
. : milestone, 15438000,
appsec (14.993 s) : 14993000, 14993000
. : milestone, 14993000,
iast (18.362 s) : 18362000, 18362000
. : milestone, 18362000,
iast_GLOBAL (18.09 s) : 18090000, 18090000
. : milestone, 18090000,
profiling (15.316 s) : 15316000, 15316000
. : milestone, 15316000,
tracing (14.887 s) : 14887000, 14887000
. : milestone, 14887000,
section candidate
no_agent (15.263 s) : 15263000, 15263000
. : milestone, 15263000,
appsec (14.825 s) : 14825000, 14825000
. : milestone, 14825000,
iast (18.61 s) : 18610000, 18610000
. : milestone, 18610000,
iast_GLOBAL (17.928 s) : 17928000, 17928000
. : milestone, 17928000,
profiling (15.044 s) : 15044000, 15044000
. : milestone, 15044000,
tracing (14.733 s) : 14733000, 14733000
. : milestone, 14733000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.46.0-SNAPSHOT~c68fa9d79a, baseline=1.47.0-SNAPSHOT~b24d15319f
dateFormat X
axisFormat %s
section baseline
no_agent (1.473 ms) : 1461, 1484
. : milestone, 1473,
appsec (2.358 ms) : 2315, 2401
. : milestone, 2358,
iast (2.119 ms) : 2064, 2174
. : milestone, 2119,
iast_GLOBAL (2.159 ms) : 2104, 2215
. : milestone, 2159,
profiling (1.981 ms) : 1937, 2025
. : milestone, 1981,
tracing (1.952 ms) : 1910, 1994
. : milestone, 1952,
section candidate
no_agent (1.473 ms) : 1461, 1484
. : milestone, 1473,
appsec (2.362 ms) : 2319, 2405
. : milestone, 2362,
iast (2.109 ms) : 2054, 2164
. : milestone, 2109,
iast_GLOBAL (2.156 ms) : 2100, 2211
. : milestone, 2156,
profiling (1.997 ms) : 1952, 2043
. : milestone, 1997,
tracing (1.948 ms) : 1906, 1991
. : milestone, 1948,
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Let's update the test environment fixtures though
What Does This Do
Adds the
_dd.test.is_user_provided_service
tag to every span, set astrue/false
depending on whether theDD_SERVICE
is specified by the user or the default value is being used.Motivation
This information can be used in Test Optimization backend and UI to differentiate between default and user-provided services.
Additional Notes
Contributor Checklist
type:
and (comp:
orinst:
) labels in addition to any usefull labelsclose
,fix
or any linking keywords when referencing an issue.Use
solves
instead, and assign the PR milestone to the issueJira ticket: SDTEST-1242