Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📝 add rum-react documentation to the integration page #2604

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

BenoitZugmeyer
Copy link
Member

@BenoitZugmeyer BenoitZugmeyer commented Feb 13, 2025

What does this PR do?

Update the rum_react integration page to add the new rum-react plugin documentation. In the future, we'll remove the documentation from the package readme and just add a link to the integration doc page.

Rendered

Motivation

We are in the process of releasing the official rum-react integration plugin.

Review checklist

  • PR has a meaningful title or PR has the no-changelog label attached
  • N/A Feature or bugfix has tests
  • Git history is clean
  • If PR impacts documentation, docs team has been notified or an issue has been opened on the documentation repo
  • N/A If this PR includes a log pipeline, please add a description describing the remappers and processors.

@BenoitZugmeyer BenoitZugmeyer requested review from a team as code owners February 13, 2025 09:50
Copy link

@Miz85 Miz85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! I only have one comment, let me know what you think.


To start collecting Real User Monitoring events from your React application, see [React Monitoring][2].
Then, install the `@datadog/browser-rum-react` NPM package using your package manager of choice. For example:
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we point to the RUM Application creation page here instead of repeating installation steps? That would avoid having to maintain the instructions in both places.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting. I changed the setup section, let me know what you think!

Copy link
Contributor

@rtrieu rtrieu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor feedback to comply with our style guide but otherwise looks good.

rum_react/README.md Outdated Show resolved Hide resolved
rum_react/README.md Outdated Show resolved Hide resolved
rum_react/README.md Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants