-
Notifications
You must be signed in to change notification settings - Fork 761
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
📝 add rum-react documentation to the integration page #2604
base: master
Are you sure you want to change the base?
📝 add rum-react documentation to the integration page #2604
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great! I only have one comment, let me know what you think.
rum_react/README.md
Outdated
|
||
To start collecting Real User Monitoring events from your React application, see [React Monitoring][2]. | ||
Then, install the `@datadog/browser-rum-react` NPM package using your package manager of choice. For example: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we point to the RUM Application creation page here instead of repeating installation steps? That would avoid having to maintain the instructions in both places.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Interesting. I changed the setup section, let me know what you think!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some minor feedback to comply with our style guide but otherwise looks good.
Co-authored-by: Rosa Trieu <[email protected]>
What does this PR do?
Update the rum_react integration page to add the new rum-react plugin documentation. In the future, we'll remove the documentation from the package readme and just add a link to the integration doc page.
Rendered
Motivation
We are in the process of releasing the official rum-react integration plugin.
Review checklist
no-changelog
label attached