feat: add remote table materialization #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -117,8 +117,7 @@ def convert_time_type(cls, agate_table: "agate.Table", col_idx: int) -> str: | |||
| @available.parse(lambda *a, **k: {}) | |||
| def get_clickhouse_cluster_name(self): | |||
| conn = self.connections.get_if_exists() | |||
| if conn.credentials.cluster: | |||
| return f'"{conn.credentials.cluster}"' | |||
| @@ -32,7 +32,7 @@ | |||
| db.engine as db_engine, | |||
| {%- if adapter.get_clickhouse_cluster_name() -%} | |||
| count(distinct _shard_num) > 1 as is_on_cluster | |||
| from clusterAllReplicas({{ adapter.get_clickhouse_cluster_name() }}, system.tables) as t | |||
| from clusterAllReplicas('{{ adapter.get_clickhouse_cluster_name() }}', system.tables) as t | |||
There was a problem hiding this comment.
All three variants work
select * from cluster(default, system.one);
select * from cluster('default', system.one);
select * from cluster("default", system.one);There was a problem hiding this comment.
I was worried about passing reserved names to the first parameter
|
|
||
| # this `remote_table` run with default configuration will point to previously created local table, taking | ||
| # `local_db_prefix` and `local_suffix` settings into account. | ||
| run_dbt() |
There was a problem hiding this comment.
create or replace table `dbt_clickhouse_3961_test_remote_table_1736978435032`.`remote_table`
(key1 UInt64, key2 Int64)
engine = Distributed('test_shard', 'dbt_clickhouse_3961_test_remote_table_1736978435032', 'remote_table_local'
, rand()
)I copied this DDL from test debugging, and I have two questions.
- What is the use case for creating a Distributed table on
test_shardwhen the base table is also ontest_shard? Wouldn't this simply overwrite the Distributed table created bydistributed_incrementalmaterialization? - I didn't dig deeper, but
on_cluster_clausereturned nothing in this case, but I believe this query should have anon cluster test_shardclause, otherwise the Distributed table will only be available on one shard.
| {%- set remote_config = config.get('remote_config', {}) -%} | ||
| {%- set remote_cluster = remote_config.get('cluster') or adapter.get_clickhouse_cluster_name() -%} | ||
| {%- set remote_schema = remote_config.get('schema') or adapter.get_clickhouse_local_db_prefix() + this.schema -%} | ||
| {%- set remote_identifier = remote_config.get('identifier') or this.identifier + adapter.get_clickhouse_local_suffix() -%} |
There was a problem hiding this comment.
Will remote_config.get('schema') be with leading underscore and remote_config.get('identifier') with _base suffix in case the base table in on the ingestion cluster?
| """) | ||
|
|
||
| # the created distributed table should point to a local table as defined in the model's `remote_config` | ||
| run_dbt() |
There was a problem hiding this comment.
create or replace table `dbt_clickhouse_3076_test_remote_table_1736979527642`.`remote_table`
(key1 UInt64, key2 Int64)
engine = Distributed('test_remote', 'dbt_clickhouse_3076_test_remote_table_1736979527642', 'remote_target_table', key1)Is on cluster test_shard also missing here?
| {{ run_hooks(pre_hooks, inside_transaction=True) }} | ||
|
|
||
| {% call statement('main') %} | ||
| {{ create_distributed_table(target_relation, remote_relation, sql) }} |
There was a problem hiding this comment.
where is the sql defined?
| {%- set remote_cluster = local_relation.remote_cluster or adapter.get_clickhouse_cluster_name() -%} | ||
| {%- set sharding = config.get('sharding_key') -%} | ||
| {%- set reference = "as " ~ local_relation -%} | ||
| {%- if sql -%} |
There was a problem hiding this comment.
what is the use case for having an SQL when creating a distributed table?
There was a problem hiding this comment.
you don't rely on an existing local relation for the ddl query. the sql will allow to directly pass the column names and types
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Materialization strategy for creating distributed engine table with arbitrary base table target