409 run tests against docker container

.github/workflows/nodejs.yml

@@ -43,5 +43,18 @@ jobs:
         DEBUG: openapi-cop:*
         CI: true
 
+    - if: startsWith(matrix.node-version, '12')
+      name: Test Docker image
+      run: npm run test:docker
+      env:
+        DEBUG: openapi-cop:*
+        CI: true
+
+    - name: Dump docker logs on failure
+      if: failure() && startsWith(matrix.node-version, '12')
+      uses: jwalton/gh-docker-logs@v2
+      with:
+        images: 'lxlu/openapi-cop:test'
+
     - name: Analyze dependencies
       run: npm run test:deps

.mocharc.json

@@ -0,0 +1,11 @@
+{
+  "bail": true,
+  "timeout": 60000,
+  "exit": true,
+  "spec": [
+    "build/test/*.test.js"
+  ],
+  "require": [
+    "dotenv/config"
+  ]
+}

.nvmrc

@@ -1 +1 @@
-10
+12

docker/Dockerfile

@@ -1,22 +1,23 @@
-FROM node:10 AS builder
+FROM node:12 AS builder
 WORKDIR /app
 COPY . .
-RUN npm ci --unsafe-perm
+RUN npm ci --no-optional --unsafe-perm
 RUN npm run compile
 
-FROM node:10 AS main
+FROM node:12 AS main
 
 ENV TARGET ""
 ENV FILE ""
 ENV DEFAULT_FORBID_ADDITIONAL_PROPERTIES ""
 ENV SILENT ""
 ENV VERBOSE ""
+ENV CLI_ARGUMENTS ""
 ENV NODE_ENV "production"
 
 WORKDIR /openapi-cop-docker
 COPY package.json .
 COPY package-lock.json .
-RUN npm ci --omit=dev
+RUN npm ci --omit=dev --no-optional
 COPY --from=builder /app/build .
 COPY docker/entrypoint.bash .
 

docker/README.md

@@ -32,6 +32,7 @@ same [openapi-cop CLI flags](https://github.com/EXXETA/openapi-cop#cli-usage):
   are not allowed.
 - `SILENT`: When set, the proxy will forward response bodies unchanged and only set validation headers.
 - `VERBOSE`: When set, activates verbose output.
+- `CLI_ARGUMENTS`: Sets all the arguments at once and overrides any other option given.
 - `NODE_ENV` (default: "production"): When set to "development", stack traces will also be logged.
 
 ### Example

docker/entrypoint.bash

@@ -22,4 +22,8 @@ if [ -n "$VERBOSE" ]; then
     cli_args="${cli_args}--verbose "
 fi
 
+if [ -n "$CLI_ARGUMENTS" ]; then
+  cli_args="$CLI_ARGUMENTS"
+fi
+
 node src/cli --host 0.0.0.0 $cli_args

mock-server/src/app.ts

@@ -139,8 +139,6 @@ export async function runApp({ port, apiDocFile }: MockOptions): Promise<http.Se
 			server = app.listen(port, () => {
 				resolve(server);
 			});
-		}).then(() => {
-			return server;
 		});
 	} catch (error) {
 		console.error('Failed to run mock server', error);