Merge shusain93 dehydrated patch, update syntax and dnspython to work with Python 3 #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Newer version of Dehydrated toss in an intentionally bad hook `this_hookscript_is_broken__dehydrated_is_working_fine__please_ignore_unknown_hooks_in_your_script` to ensure that scripts are halding unknown hooks properly, aka ignoring them. It detects if it's handling it properly by testing if it outputs anything which means we need to exit normally without error on unkown hooks
From [github.com/ezhes/dehydrated-dreamhost-hook](https://github.com/ezhes/dehydrated-dreamhost-hook/tree/patch-1), also available at [gitlab.com/ErinMorelli/dehydrated-dreamhost-hook!3](https://gitlab.com/ErinMorelli/dehydrated-dreamhost-hook/-/merge_requests/3)
Not entirely sure what I am doing, but now it works for me under Python 3 in asuswrt-merlin / entware on a RT-AX56U Update to dnspython 2.0.0 which is compatible with Python 3 See [whats new](https://dnspython.readthedocs.io/en/stable/whatsnew.html)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi! I found your script useful, though unfortunately outdated. With these fixes, it works for me on a current setup
Best regards
CJ