Navigate route with rerouting #316
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TADraeseke
approved these changes
Feb 6, 2025
...cgismaps/sample/navigateroutewithrerouting/components/NavigateRouteWithReroutingViewModel.kt
Outdated
Show resolved
Hide resolved
...cgismaps/sample/navigateroutewithrerouting/components/NavigateRouteWithReroutingViewModel.kt
Show resolved
Hide resolved
...cgismaps/sample/navigateroutewithrerouting/components/NavigateRouteWithReroutingViewModel.kt
Outdated
Show resolved
Hide resolved
...cgismaps/sample/navigateroutewithrerouting/components/NavigateRouteWithReroutingViewModel.kt
Outdated
Show resolved
Hide resolved
...cgismaps/sample/navigateroutewithrerouting/components/NavigateRouteWithReroutingViewModel.kt
Outdated
Show resolved
Hide resolved
eri9000
reviewed
Feb 11, 2025
samples-lib/src/main/java/com/esri/arcgismaps/sample/sampleslib/components/MessageDialog.kt
Outdated
Show resolved
Hide resolved
...cgismaps/sample/navigateroutewithrerouting/components/NavigateRouteWithReroutingViewModel.kt
Show resolved
Hide resolved
...cgismaps/sample/navigateroutewithrerouting/components/NavigateRouteWithReroutingViewModel.kt
Show resolved
Hide resolved
...cgismaps/sample/navigateroutewithrerouting/components/NavigateRouteWithReroutingViewModel.kt
Outdated
Show resolved
Hide resolved
...cgismaps/sample/navigateroutewithrerouting/components/NavigateRouteWithReroutingViewModel.kt
Outdated
Show resolved
Hide resolved
Comment on lines
+185
to
+186
| // Reset navigation to initial state | ||
| resetNavigation() |
There was a problem hiding this comment.
wondering why this needs to be called on initialization?
In what cases will the navigation needs to be reset when initializing?
There was a problem hiding this comment.
Use cases:
initialize():
- Sets up location display
- Sets up text-to-speech
- Loads map and load route result
- Tigger reset
resetNavigation():
- Cancels navigation job. (not needed for initialization)
- Fix map rotation to north up. (not needed for initialization)
- Set viewpoint to route result. (needed for initialization & reset)
- Create the route ahead graphics and add them to the map. (needed for initialization & reset)
- Set up button states. (needed for initialization & reset)
To avoid repeated code on initialize & resetNavigation, I designed it so initialize loads, calculate the required resources, and then call the reset function to reset navigation to an initial (non-navigating) state. If there is a name change that may work better than resetNavigation, feel free to comment below.
There was a problem hiding this comment.
thanks for the well detailed explanation.
...cgismaps/sample/navigateroutewithrerouting/components/NavigateRouteWithReroutingViewModel.kt
Show resolved
Hide resolved
...sri/arcgismaps/sample/navigateroutewithrerouting/screens/NavigateRouteWithReroutingScreen.kt
Outdated
Show resolved
Hide resolved
...cgismaps/sample/navigateroutewithrerouting/components/NavigateRouteWithReroutingViewModel.kt
Outdated
Show resolved
Hide resolved
|
Thank you for the review @eri9000, I added in the PR comments & feedback changes, and the PR is now ready for your re-review. 👍 |
eri9000
approved these changes
Feb 13, 2025
| fontWeight = FontWeight.Bold | ||
| ) | ||
| Text( | ||
| text = timeRemainingText, |
There was a problem hiding this comment.
To improve visibility, can you add a space in between the title and text?
applies to the others as well
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
PR to add a new Kotlin sample "Navigate route with rerouting" in
Routing and Logisticscategory.Links and Data
Sample issue: #1414
What To Review
README.mdandREADME.metadata.jsonfiles