Find nearest vertex sample

[darryl-lynch]

Description

Adding more functionality to the create and edit geometries working branch

Links and Data

Issues: https://devtopia.esri.com/runtime/kotlin/issues/4989
vTest: https://runtime-kotlin.esri.com/view/all/job/vtest/job/sampleviewer/80/

What To Review

Review like ordinary sample. The delete button is of particular interest since a new dropdown was added to try make it fit and have sufficient detail on what it does. Will fail style checks as README will likely be part of final stage.

How to Test

Run the sample on the sample viewer or the repo.

[01smito01]

Looks good, not much to add.

[01smito01]

There's quite a lot going on here, would be a good idea to do the calculations for these in their own method.

Unchecked null asserts are also not a good idea - since vertexDistance and coordinateDistance are only used to update _distanceInformationFlow we can leave these nullable and do a check there.

[darryl-lynch]

I've fixed the unchecked null assert, but I can't find a good way to break up the calculation. I feel like if I did I'd need to take the source for the calculation out too, and then that would be 80% of the method anyway. It's less than ideal but this is how the original sample does it.

[01smito01]

Did a search and 5280 is the number of feet in a mile. Can do an extension function on Double:

    /**
     * Converts a quantity in feet to miles.
     */
    private fun Double.feetToMiles(): Double {
        return this/5280.0
    }

which then allows this:

        val vertexDistance = nearestVertexResult?.distance?.feetToMiles()?.toInt()
        val coordinateDistance = nearestCoordinateResult?.distance?.feetToMiles()?.toInt()

Which is a bit more readable.
Could do the int conversion in the extension, but I think it's better to leave that as its own thing or move it into the call to DistanceInformation, or change the typing on DistanceInformation, (etc).