feat(hub-common): hubSearchEvents switch to new POST events search route #1787
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
velveetachef
force-pushed
the
f/12274-hubSearchEvents-use-new-post-search-events-route
branch
from
bf96ac7 to
fa81971
Compare
ethanspiro
approved these changes
Jan 30, 2025
juliannaeapicella
approved these changes
Jan 30, 2025
rweber-esri
approved these changes
Jan 31, 2025
There was a problem hiding this comment.
LGTM, I pulled this branch into my opendata-ui sandbox and verified things are working as expected. Nj!
One minor request, would you remind removing this line as userId is not a supported filter.
affects: @esri/hub-common
affects: @esri/hub-common
affects: @esri/hub-common
affects: @esri/hub-common
affects: @esri/hub-common
affects: @esri/hub-common
velveetachef
force-pushed
the
f/12274-hubSearchEvents-use-new-post-search-events-route
branch
from
98a0d14 to
945a1d1
Compare
velveetachef
deleted the
f/12274-hubSearchEvents-use-new-post-search-events-route
branch
esri-dcdev-2
pushed a commit
that referenced
this pull request
Jan 31, 2025
# @esri/hub-common [15.26.0](https://github.com/Esri/hub.js/compare/@esri/[email protected]...@esri/[email protected]) (2025-01-31) ### Features * **hub-common:** hubSearchEvents switch to new POST events search route ([#1787](#1787)) ([8fbb944](8fbb944))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
affects: @esri/hub-common
https://devtopia.esri.com/dc/hub/issues/12274
Description: In
hubSearchEvents, swapgetEventswithsearchEvents. This function points to the new POST /events/search route. Update the process filter and options functions for the new interface (remove parsing to string)Instructions for testing:
Closes Issues: # (if appropriate)
Updated meaningful TSDoc to methods including Parameters and Returns, see Documentation Guide
used semantic commit messages
PR title follows semantic commit format (CRITICAL if the title is not in a semantic format, the release automation will not run!)
updated
peerDependenciesas needed. CRITICAL our automated release system can not be counted on to updatepeerDependenciesso we must do it manually in our PRs when needed. See the updating peerDependencies section of the release instructions for more details.