Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update NT data; history interpolation #2

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Update NT data; history interpolation #2

wants to merge 5 commits into from

Conversation

rjbell4
Copy link

@rjbell4 rjbell4 commented Mar 9, 2020 •
edited
Loading

Update NetworkTables interaction to read frame count from target data array (requires sync with co-processor)

Add interpolation to azimuth history, with unit tests

Still needs verification on the robot

@rjbell4 rjbell4 requested a review from coach-streeter March 9, 2020 05:38
@rjbell4 rjbell4 self-assigned this Mar 9, 2020
@rjbell4 rjbell4 changed the title Bob's pending changes Update NT data; history interpolation Mar 10, 2020
@rjbell4 rjbell4 marked this pull request as ready for review March 10, 2020 16:31
coach-streeter
coach-streeter approved these changes Mar 10, 2020
View reviewed changes
Copy link
Contributor

@coach-streeter coach-streeter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing old target types seems like a good change to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coach-streeter coach-streeter coach-streeter approved these changes

Assignees

@rjbell4 rjbell4

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rjbell4 @coach-streeter