Improve how thread priority is applied #162
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… object to better handle setting and restoring it. Also change what each of the levels mean now that enums let specific behaviour be assigned. Have also snuck in some extra changes in this commit that I'll be pulling out into other PRs
…t be emitted (#161) This pulls the logging code out into its own class as it was getting more complex. It also allows limiting sending of logs from a reactor. Sending out every trace message was causing a lot of overhead. Now there are two variables in each reactor, one to describe the displayed log level `log_level` and one to describe the minimum emitted log level `min_log_level`
…s, the actual time taken doesn't matter
…t I don't care about coverage on anyway
Bidski
requested changes
Feb 12, 2025
|
It is important to note that when testing some of these UnitTests will require elevated permissions: sudo setcap 'cap_sys_nice=eip' ./tests/util/ThreadPriority |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Restore the API keeping the enums, and make ThreadPriority be an RAII object to better handle setting and restoring it. Also change what each of the levels mean now that enums let specific behaviour be assigned.