Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] Replacing ssize_t -> int #3

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

zamazan4ik
Copy link
Contributor

ssize_t is not standard ISO type. I think, you should use int instead of ssize_t.

@FooBarWidget
Copy link
Owner

Thank you for the pull request. But sorry, I don't think this is a good idea. int doesn't convey what I want to express. Especially because I use size_t elsewhere in the code, int might be too small.

If you're worried about compatibility then maybe it's a good idea to define our own sbmh_data_ssize_t type, which aliases to ssize_t when available, or int otherwise.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants