Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: handle foreign key toward non primary key with virtual field #473

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

GuillaumeCisco
Copy link
Contributor

Pull Request checklist:

  • Write an explicit title for the Pull Request, following Conventional Commits specification
  • Create automatic tests
  • Test manually the implemented changes
  • Review my own code (indentation, syntax, style, simplicity, readability)
  • Wonder if you can improve the existing code

@codeclimate
Copy link

codeclimate bot commented Jan 4, 2021

Code Climate has analyzed commit 7a8cc0d and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 80.0% (60% is the threshold).

This pull request will bring the total coverage in the repository to 55.8% (0.0% change).

View more on Code Climate.

@GuillaumeCisco GuillaumeCisco marked this pull request as draft January 5, 2021 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant