Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dumper): ignore mongodb fields that includes column and log warning #652

Merged
merged 9 commits into from
Dec 7, 2023

Conversation

SteveBunlon
Copy link
Member

@SteveBunlon SteveBunlon commented Dec 6, 2023

https://app.clickup.com/t/860t35ffj

Definition of Done

General

  • Write an explicit title for the Pull Request, following Conventional Commits specification
  • Test manually the implemented changes
  • Validate the code quality (indentation, syntax, style, simplicity, readability)

Security

  • Consider the security impact of the changes made

@SteveBunlon SteveBunlon changed the title Fix/remove and warn fields with semicolumn fix(dumper): ignore mongodb fields that includes semicolumn and log warning Dec 6, 2023
@SteveBunlon SteveBunlon marked this pull request as draft December 6, 2023 19:01
@SteveBunlon SteveBunlon marked this pull request as ready for review December 6, 2023 20:40
@arnaud-moncel arnaud-moncel changed the base branch from main to fix/special-characters December 7, 2023 08:42
@SteveBunlon SteveBunlon changed the title fix(dumper): ignore mongodb fields that includes semicolumn and log warning fix(dumper): ignore mongodb fields that includes column and log warning Dec 7, 2023
Copy link
Member

@arnaud-moncel arnaud-moncel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It working nice :) tested on my end.
Please just change the warning message 🙏

src/services/dumpers/agent-nodejs.ts Outdated Show resolved Hide resolved
src/services/dumpers/agent-nodejs.ts Outdated Show resolved Hide resolved
Base automatically changed from fix/special-characters to main December 7, 2023 10:08
@SteveBunlon SteveBunlon force-pushed the fix/remove-and-warn-fields-with-semicolumn branch from c26bba0 to 05cbf75 Compare December 7, 2023 10:17
@SteveBunlon SteveBunlon merged commit e940447 into main Dec 7, 2023
7 checks passed
@SteveBunlon SteveBunlon deleted the fix/remove-and-warn-fields-with-semicolumn branch December 7, 2023 10:26
forest-bot added a commit that referenced this pull request Dec 7, 2023
## [4.2.5](v4.2.4...v4.2.5) (2023-12-07)

### Bug Fixes

* **dumper:** ignore mongodb fields that includes column and log warning ([#652](#652)) ([e940447](e940447))
@forest-bot
Copy link
Member

🎉 This PR is included in version 4.2.5 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants