Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Implement replies count detection for submissions #125

Draft
wants to merge 1 commit into
base: edge
Choose a base branch
from
Draft

feat: Implement replies count detection for submissions #125

wants to merge 1 commit into from

Conversation

FoxxMD
Copy link
Owner

@FoxxMD FoxxMD commented Nov 1, 2022

Work for #8

@FoxxMD
Copy link
Owner Author

FoxxMD commented Nov 1, 2022 •
edited
Loading

Notes:

  • Sticked comment is always first returned comment for submission (depth 0) regardless of sort order
  • Comment tree context and replies are ONLY initially hydrated if picked from fetched submissions
    • When fetching a single comment (getComment('asdf')) snoowrap uses /api/info which DOES NOT return:
      • depth
      • replies

This is a big issue since we cannot check comment depth, number of replies, or contents of any replies unless we make an additional api call. And even with the additional call we still do not know what depth the original comment was at. Need to take a look at what PRAW is doing for refresh to get additional information.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@FoxxMD