Fix featherlight modal fetching wrong revision

GuLinux · Oct 10, 2022 · 7824eb4 · 7824eb4
1 parent 3053b4f
commit 7824eb4
Show file tree

Hide file tree

Showing 4 changed files with 11 additions and 5 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,13 +1,19 @@
+# v1.0.6
+## 11/10/2022
+
+1. [](#bugfix)
+    * Fix featherlight modal by setting unique ID for featherlight figure using revision as well as image ID.
+
 # v1.0.5
 ## 11/10/2022
 
-1. [](#new)
+1. [](#bugfix)
     * Fix revision tag by using match by label
 
 # v1.0.4
 ## 01/01/2018
 
-1. [](#new)
+1. [](#bugfix)
     * Properly catch exceptions
 
 # v1.0.3

diff --git a/blueprints.yaml b/blueprints.yaml
@@ -1,5 +1,5 @@
 name: Astrobin
-version: 1.0.3
+version: 1.0.6
 description: "This plugin provides astrobin shortcodes for images and galleries"
 icon: picture-o
 author:

diff --git a/templates/partials/astrobin-image-lightbox.html.twig b/templates/partials/astrobin-image-lightbox.html.twig
@@ -1,4 +1,4 @@
- <figure id="lightbox-{{ image.id() }}" class="astrobin-lightbox {{params['image_lightbox_class']}}">
+ <figure id="lightbox-{{ image.id() }}-{{ params['revision']}}" class="astrobin-lightbox {{params['image_lightbox_class']}}">
     <figcaption>
         <h4 class="astrobin-lightbox-title">{{ image.title() }}</h4>
         <div class="astrobin-lightbox-links">

diff --git a/templates/partials/astrobin-image.html.twig b/templates/partials/astrobin-image.html.twig
@@ -1,4 +1,4 @@
-<a href="#" data-featherlight="#lightbox-{{ image.id() }}" class="astrobin-image {{params['image_class']}}">
+<a href="#" data-featherlight="#lightbox-{{ image.id() }}-{{params['revision']}}" class="astrobin-image {{params['image_class']}}">
     <figure>
         <img src="{{ image.url(params['format_image'], params['revision'], params['animated']) }}">
         <figcaption>{{ image.title() }}</figcaption>