Update authorization header encoding #253
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ings instead of byte strings.
|
I respectfully ask if you could review and possibly merge this PR. Thank you! |
| @@ -351,14 +351,14 @@ def getHeaders(self, username=None, password=None, headers=None): | |||
|
|
|||
| if token: | |||
| auth_string = b"Bearer " + token.encode("ascii") | |||
| headers["Authorization"] = auth_string | |||
| headers["Authorization"] = auth_string.decode("ascii") | |||
There was a problem hiding this comment.
I chose ascii as the encoding here to align with the token encoding above.
TBH I am not sure why this is ascii and not utf-8.
|
Awesome - thank you for accepting it! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running in Pyodide inside a browser, it appears that the request library puts the literal string value of headers in browser fetch requests.
By leaving the value as a byte string, it ends up being sent as
Authorization: b'Basic ...'.There are different ways to approach this isssue, but ultimately headers are strings and so this fixes the issue by decoding the value before setting the header.