Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issue #18 by creating a link to libdf #801

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix issue #18 by creating a link to libdf #801

wants to merge 2 commits into from

Conversation

byrnHDF
Copy link
Collaborator

@byrnHDF byrnHDF commented Jan 28, 2025

No description provided.

@byrnHDF byrnHDF added Component - Build CMake, Autotools Component - Misc Anything else (CODEOWNERS, etc.) Type - Improvement Improvements that don't add a new feature or functionality Priority - 0. Blocker ⛔ This MUST be merged for the release to happen labels Jan 28, 2025
@byrnHDF byrnHDF self-assigned this Jan 28, 2025
@bmribler
Copy link
Collaborator

bmribler commented Jan 28, 2025 •
edited
Loading

So, LIB vs LIBSH is what determines hdf or mfhdf libraries?

@byrnHDF
Copy link
Collaborator Author

byrnHDF commented Jan 28, 2025

So, LIB vs LIBSH is what determines hdf or mfhdf libraries?

no, static vs shared

@bmribler
Copy link
Collaborator

Oh, ok, so which line is the fix for this issue?

@byrnHDF
Copy link
Collaborator Author

byrnHDF commented Jan 28, 2025

Oh, ok, so which line is the fix for this issue?

Not sure what you need, the changes are the minimal needed so that libdf is in the installtion

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lrknox lrknox Awaiting requested review from lrknox lrknox is a code owner

@derobins derobins Awaiting requested review from derobins derobins is a code owner

@fortnern fortnern Awaiting requested review from fortnern fortnern is a code owner

@jhendersonHDF jhendersonHDF Awaiting requested review from jhendersonHDF jhendersonHDF is a code owner

@vchoi-hdfgroup vchoi-hdfgroup Awaiting requested review from vchoi-hdfgroup vchoi-hdfgroup is a code owner

@bmribler bmribler Awaiting requested review from bmribler bmribler is a code owner

@glennsong09 glennsong09 Awaiting requested review from glennsong09 glennsong09 is a code owner

@mattjala mattjala Awaiting requested review from mattjala mattjala is a code owner

@brtnfld brtnfld Awaiting requested review from brtnfld brtnfld is a code owner

@schwehr schwehr Awaiting requested review from schwehr schwehr is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

@byrnHDF byrnHDF

Labels
Component - Build CMake, Autotools Component - Misc Anything else (CODEOWNERS, etc.) Priority - 0. Blocker ⛔ This MUST be merged for the release to happen Type - Improvement Improvements that don't add a new feature or functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@byrnHDF @bmribler