Skip to content

Commit

Permalink
Remove more autotool files and references
Browse files Browse the repository at this point in the history
  • Loading branch information
byrnHDF committed Jan 17, 2025
1 parent 20d593f commit aab5bb8
Show file tree
Hide file tree
Showing 51 changed files with 1,197 additions and 5,263 deletions.
306 changes: 179 additions & 127 deletions .gitattributes

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion .github/ISSUE_TEMPLATE/bug_report.md
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ A clear and concise description of what you expected to happen.
- HDF5 version (if building from a maintenance branch, please include the commit hash)
- OS and version
- Compiler and version
- Build system (e.g. CMake, Autotools) and version
- Build system (e.g. CMake) and version
- Any configure options you specified
- MPI library and version (parallel HDF5)

Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/main-cmake.yml
Original file line number Diff line number Diff line change
Expand Up @@ -39,8 +39,8 @@ jobs:
- "MacOS Clang"

# This is where we list the bulk of the options for each configuration.
# The key-value pair values are usually appropriate for being CMake or
# Autotools configure values, so be aware of that.
# The key-value pair values are usually appropriate for being CMake
# configure values, so be aware of that.

include:

Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/tarball.yml
Original file line number Diff line number Diff line change
Expand Up @@ -97,10 +97,10 @@ jobs:
path: hdfsrc
ref: '${{needs.check_commits.outputs.branch_ref }}'

- name: Install Autotools Dependencies (Linux, serial)
- name: Install Dependencies (Linux, serial)
run: |
sudo apt update
sudo apt install automake autoconf libtool libtool-bin gzip dos2unix
sudo apt install gzip dos2unix
- name: Retrieve version
id: version
Expand Down
30 changes: 0 additions & 30 deletions .github/workflows/vfd-subfiling.yml
Original file line number Diff line number Diff line change
Expand Up @@ -71,20 +71,6 @@ jobs:
- name: Checkout HDF5
uses: actions/[email protected]

- name: Configure HDF5 with Subfiling VFD (Autotools)
shell: bash
run: |
sh ./autogen.sh
mkdir "${{ runner.workspace }}/build"
cd "${{ runner.workspace }}/build"
$GITHUB_WORKSPACE/configure \
--enable-build-mode=${{ inputs.build_mode }} \
--enable-shared \
--disable-static \
--enable-parallel \
--enable-subfiling-vfd \
if: ${{ inputs.build_sys == 'Autotools' }}

- name: Configure HDF5 with Subfiling VFD (CMake)
shell: bash
run: |
Expand All @@ -101,12 +87,6 @@ jobs:
cat src/libhdf5.settings
if: ${{ inputs.build_sys == 'CMake' }}

- name: Build HDF5 (Autotools)
shell: bash
working-directory: ${{ runner.workspace }}/build
run: make -j3
if: ${{ inputs.build_sys == 'Autotools' }}

- name: Build HDF5 (CMake)
shell: bash
working-directory: ${{ runner.workspace }}/build
Expand All @@ -115,16 +95,6 @@ jobs:
echo "LD_LIBRARY_PATH=${{ runner.workspace }}/build/bin" >> $GITHUB_ENV
if: ${{ inputs.build_sys == 'CMake' }}

- name: Test HDF5 Subfiling VFD (Autotools)
working-directory: ${{ runner.workspace }}/build/testpar
# For now, just run the tests directly setup for use with the
# Subfiling VFD. We can expand on this once the library's tests
# are better separated into categories for VFD testing.
run: |
mpirun -np 2 t_subfiling_vfd
mpirun -np 2 t_vfd
if: ${{ inputs.build_sys == 'Autotools' }}

- name: Test HDF5 Subfiling VFD (CMake)
working-directory: ${{ runner.workspace }}/build
run: |
Expand Down
18 changes: 4 additions & 14 deletions .github/workflows/vfd.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,27 +13,17 @@ jobs:
build_and_test:
strategy:
matrix:
build_sys: ["CMake", "Autotools"]
build_sys: ["CMake"]
build_mode: ["Release", "production", "Debug", "debug"]
include:
- build_sys: "CMake"
build_mode: "Release"
- build_sys: "CMake"
build_mode: "Debug"
- build_sys: "Autotools"
build_mode: "production"
- build_sys: "Autotools"
build_mode: "debug"
# Exclude mismatched configurations
exclude:
- build_sys: "CMake"
build_mode: "production"
- build_sys: "CMake"
build_mode: "debug"
- build_sys: "Autotools"
build_mode: "Release"
- build_sys: "Autotools"
build_mode: "Debug"
# exclude:
# - build_sys: "xxx"
# build_mode: "yyy"

# Sets the job's name from the properties
name: "${{ matrix.build_sys }} ${{ matrix.build_mode }} Workflows"
Expand Down
18 changes: 2 additions & 16 deletions .h5chkright.ini
Original file line number Diff line number Diff line change
Expand Up @@ -23,21 +23,6 @@ skip LICENSE
# Sort of strange to have a copyright notice in README
skip README

# Non-UI copyrighted files in top-level
skip aclocal.m4

# Non-UI copyrighted files in bin.
skip config.guess
skip config.sub
skip depcomp
skip install-sh
skip ltmain.sh
skip missing
skip mkinstalldirs

# Generated files in top-level
skip configure

# Generated files in src.
skip H5config.h.in

Expand All @@ -48,6 +33,7 @@ skip H5test_kind.f90
# Ignore this expected output file in windows/examples.
skip testExamples_exp_output.txt

# Skip all testfiles/* since if we insert a copyright notice in the expected
# Skip all testfiles/* and tfiles/* since if we insert a copyright notice in the expected
# data files, we would have to spend extra effort to filter them out.
prune testfiles
prune tfiles
221 changes: 221 additions & 0 deletions HDF5Examples/C/H5D/test-pc.sh
Original file line number Diff line number Diff line change
@@ -0,0 +1,221 @@
#! /bin/sh
#
# Copyright by The HDF Group.
# All rights reserved.
#
# This file is part of HDF5. The full HDF5 copyright notice, including
# terms governing use, modification, and redistribution, is contained in
# the LICENSE file, which can be found at the root of the source code
# distribution tree, or in https://www.hdfgroup.org/licenses.
# If you do not have access to either file, you may request a copy from
# [email protected].

# This file is for use of h5cc created with the CMake process
# HDF5_HOME is expected to be set

srcdir=..
builddir=.
verbose=yes
nerrors=0

# HDF5 compile commands, assuming they are in your $PATH.
H5CC=$HDF5_HOME/bin/h5cc
LD_LIBRARY_PATH=$HDF5_HOME/lib
export LD_LIBRARY_PATH

if ! test -f $H5CC; then
echo "Set paths for H5CC and LD_LIBRARY_PATH in test.sh"
echo "Set environment variable HDF5_HOME to the hdf5 install dir"
echo "h5cc was not found at $H5CC"
exit $EXIT_FAILURE
fi

H5DUMP=`echo $H5CC | sed -e 's/\/[^/]*$/\/h5dump/'`;
H5_LIBVER=$($H5CC -showconfig | grep -i "HDF5 Version:" | sed 's/^.* //g' | sed 's/[-].*//g')
H5_APIVER=$($H5CC -showconfig | grep -i "Default API mapping:" | sed 's/^.* //g' | sed 's/v//g' | sed 's/1/1_/')

H5_MAJORVER=$(echo $H5_LIBVER | cut -f1 -d'.' | sed -E 's/\./_/g')
H5_MINORVER=$(echo $H5_LIBVER | cut -f2 -d'.' | sed -E 's/\./_/g')
H5_RELEASEVER=$(echo $H5_LIBVER | cut -f3 -d'.' | sed -E 's/\./_/g')
H5_LIBVER_DIR=$H5_MAJORVER$H5_MINORVER

# Shell commands used in Makefiles
RM="rm -rf"
DIFF="diff -c"
CMP="cmp -s"
GREP='grep'
CP="cp -p" # Use -p to preserve mode,ownership,timestamps
DIRNAME='dirname'
LS='ls'
AWK='awk'

# setup plugin path
ENVCMD="env HDF5_PLUGIN_PATH=$LD_LIBRARY_PATH/plugin"

TESTDIR=$builddir


case `echo "testing\c"; echo 1,2,3`,`echo -n testing; echo 1,2,3` in
*c*,-n*) ECHO_N= ECHO_C='
' ;;
*c*,* ) ECHO_N=-n ECHO_C= ;;
*) ECHO_N= ECHO_C='\c' ;;
esac
ECHO_N="echo $ECHO_N"


exout() {
$*
}

dumpout() {
$H5DUMP $*
}

# compare current version, required version.
# returns if cur_ver < req_ver is true.
version_compare() {
version_lt=0
if [ ! "$(printf '%s\n' "$1" "$2" | sort -V | head -n1)" = "$2" ]; then
version_lt=1
fi
}


topics="alloc checksum chunk compact extern fillval gzip hyper \
rdwr shuffle szip unlimadd unlimgzip unlimmod"
topics18=""

version_compare "$H5_LIBVER" "1.8.0"
# check if HDF5 version is < 1.8.0
if [ "$version_lt" = 1 ]; then
dir16="/16"
else
dir16=""
topics18="nbit sofloat soint transform"
fi

return_val=0

#Remove external data file from h5ex_d_extern
rm -f h5ex_d_extern.data

for topic in $topics
do
$H5CC $srcdir/h5ex_d_$topic.c -o h5ex_d_$topic
done

for topic in $topics
do
fname=h5ex_d_$topic
$ECHO_N "Testing C/H5D/$fname...$ECHO_C"
exout .$dir16/$fname >tmp.test
status=$?
if test $status -eq 1
then
echo " Unsupported feature"
status=0
else
cmp -s tmp.test $srcdir/tfiles/16/$fname.tst
status=$?
if test $status -ne 0
then
echo " FAILED!"
else
dumpout $fname.h5 >tmp.test
rm -f $fname.h5
cmp -s tmp.test $srcdir/tfiles/16/$fname.ddl
status=$?
if test $status -ne 0
then
echo " FAILED!"
else
echo " Passed"
fi
fi
return_val=`expr $status + $return_val`
fi
done

#######Non-standard tests#######
USE_ALT=""
### Set default tfiles directory for tests
nbitdir="18"
version_compare "$H5_LIBVER" "1.8.23"
# check if HDF5 version is < 1.8.23
if [ "$version_lt" = 1 ]; then
USE_ALT="22"
else
# check if HDF5 version is >= 1.10.0 and < 1.10.8
version_compare "$H5_LIBVER" "1.10.0"
if [ "$version_lt" = 0 ]; then
version_compare "$H5_LIBVER" "1.10.8"
if [ "$version_lt" = 1 ]; then
USE_ALT="07"
nbitdir="110"
fi
fi
fi

for topic in $topics18
do
$H5CC $srcdir/h5ex_d_$topic.c -o h5ex_d_$topic
done

for topic in $topics18
do
fname=h5ex_d_$topic
$ECHO_N "Testing C/H5D/$fname...$ECHO_C"
exout ./$fname >tmp.test
status=$?
if test $status -eq 1
then
echo " Unsupported feature"
status=0
else
if [[ $fname == "h5ex_d_nbit" ]]
then
tdir=$nbitdir
if [[ $USE_ALT == "" ]]
then
### set USE_ALT=07 if not set above
USE_ALT="07"
fi
else
tdir=18
### unset USE_ALT for the other topics
USE_ALT=""
fi
cmp -s tmp.test $srcdir/tfiles/18/$fname.tst
status=$?
if test $status -ne 0
then
echo " FAILED!"
else
if [[ $fname == "h5ex_d_transform" ]]
then
targ="-n"
else
targ=""
fi
dumpout $targ $fname.h5 >tmp.test
rm -f $fname.h5
cmp -s tmp.test $srcdir/tfiles/$tdir/$fname$USE_ALT.ddl
status=$?
if test $status -ne 0
then
echo " FAILED!"
else
echo " Passed"
fi
fi
return_val=`expr $status + $return_val`
fi
done


#Remove external data file from h5ex_d_extern
rm -f h5ex_d_extern.data
rm -f tmp.test
echo "$return_val tests failed in C/H5D/"
exit $return_val
Loading

0 comments on commit aab5bb8

Please sign in to comment.