Enable API tests by default and fix some issues #5223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhendersonHDF
added
Priority - 2. Medium ⏹
jhendersonHDF
requested review from
lrknox,
derobins,
byrnHDF,
fortnern,
qkoziol,
vchoi-hdfgroup,
bmribler,
glennsong09,
mattjala and
brtnfld
as code owners
jhendersonHDF
commented
Jan 10, 2025
| @@ -26,7 +26,7 @@ | |||
| option (HDF5_DISABLE_TESTS_REGEX "Regex pattern to set execution of specific tests to DISABLED" "") | |||
| mark_as_advanced (HDF5_DISABLE_TESTS_REGEX) | |||
|
|
|||
| option (HDF5_TEST_API "Execute HDF5 API tests" OFF) | |||
| option (HDF5_TEST_API "Execute HDF5 API tests" ON) | |||
There was a problem hiding this comment.
Not sure if this change is worth a release note or not
There was a problem hiding this comment.
Since it's changing a default, a simple one line should be enough. Definitely not newsletter worthy.
jhendersonHDF
commented
Jan 10, 2025
| @@ -897,6 +897,12 @@ test_create_hard_link_invalid_params(void H5_ATTR_UNUSED *params) | |||
| PART_ERROR(H5Lcreate_hard_across_files); | |||
| } | |||
|
|
|||
| if (H5Fclose(ext_file_id) < 0) { | |||
There was a problem hiding this comment.
This file handle needed to be closed before attempting to remove the file on Windows
byrnHDF
approved these changes
Jan 10, 2025
mattjala
approved these changes
Jan 10, 2025
derobins
approved these changes
Jan 10, 2025
qkoziol
pushed a commit
to qkoziol/hdf5
that referenced
this pull request
Jan 13, 2025
* Enable API tests by default * Fix leaked file handle in API link test * Fix some versioned API misuses
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.