Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Parse ros3 VFD URLs using libcurl #5226

Merged
merged 4 commits into from
Jan 13, 2025
Merged

Parse ros3 VFD URLs using libcurl #5226

merged 4 commits into from
Jan 13, 2025

Conversation

derobins
Copy link
Member

Instead of hand-crafted, more limited code.

Parse ros3 VFD URLs using libcurl
8731b39 
Instead of hand-crafted, more limited code.
@derobins derobins added Priority - 1. High 🔼 These are important issues that should be resolved in the next release Component - C Library Core C library issues (usually in the src directory) Component - Testing Code in test or testpar directories, GitHub workflows Type - Improvement Improvements that don't add a new feature or functionality labels Jan 11, 2025
qkoziol
qkoziol previously approved these changes Jan 11, 2025
View reviewed changes
Fix missing free() calls
ed12b7b 
The ros3 and s3comms tests are valgrind-clean now
qkoziol
qkoziol previously approved these changes Jan 12, 2025
View reviewed changes
byrnHDF
byrnHDF previously approved these changes Jan 13, 2025
View reviewed changes
@derobins derobins dismissed stale reviews from byrnHDF and qkoziol via 3f7dd9c January 13, 2025 14:15
@derobins derobins merged commit 915722a into HDFGroup:develop Jan 13, 2025
76 checks passed
qkoziol pushed a commit to qkoziol/hdf5 that referenced this pull request Jan 13, 2025
@derobins @qkoziol
Parse ros3 VFD URLs using libcurl (HDFGroup#5226)
45193e1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@byrnHDF byrnHDF byrnHDF approved these changes

@qkoziol qkoziol qkoziol left review comments

@lrknox lrknox Awaiting requested review from lrknox lrknox is a code owner

@fortnern fortnern Awaiting requested review from fortnern fortnern is a code owner

@jhendersonHDF jhendersonHDF Awaiting requested review from jhendersonHDF jhendersonHDF is a code owner

@vchoi-hdfgroup vchoi-hdfgroup Awaiting requested review from vchoi-hdfgroup vchoi-hdfgroup is a code owner

@bmribler bmribler Awaiting requested review from bmribler bmribler is a code owner

@glennsong09 glennsong09 Awaiting requested review from glennsong09 glennsong09 is a code owner

@mattjala mattjala Awaiting requested review from mattjala mattjala is a code owner

@brtnfld brtnfld Awaiting requested review from brtnfld brtnfld is a code owner

Assignees
No one assigned
Labels
Component - C Library Core C library issues (usually in the src directory) Component - Testing Code in test or testpar directories, GitHub workflows Priority - 1. High 🔼 These are important issues that should be resolved in the next release Type - Improvement Improvements that don't add a new feature or functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@derobins @qkoziol @byrnHDF