Comment cleanup in s3comms code #5236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also renames the curl callback
derobins
added
Priority - 3. Low 🔽
derobins
requested review from
lrknox,
byrnHDF,
fortnern,
jhendersonHDF,
qkoziol,
vchoi-hdfgroup,
bmribler,
glennsong09,
mattjala and
brtnfld
as code owners
derobins
commented
Jan 14, 2025
| @@ -36,7 +36,8 @@ | |||
| #define H5VL_MAP_OPEN 2 /**< Callback operation ID for map open \since 1.12.0 */ | |||
| #define H5VL_MAP_GET_VAL \ | |||
| 3 /**< Callback operation ID for getting an associated value from a map \since 1.12.0 */ | |||
| #define H5VL_MAP_EXISTS 4 /**< Callback operation ID for checking if a value exists in a map \since 1.12.0 \ | |||
| #define H5VL_MAP_EXISTS \ | |||
| 4 /**< Callback operation ID for checking if a value exists in a map \since 1.12.0 \ | |||
There was a problem hiding this comment.
This is from Binh-Minh's last PR
lrknox
approved these changes
Jan 14, 2025
byrnHDF
approved these changes
Jan 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also renames the curl callback