Sync Feature/sparse data with develop #5243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add sanitzers and coverage workflows * add UndefinedBehavior sanitize
…s unexpe… (HDFGroup#4939) * Fix for issue HDFGroup#4849 that settings in fapl libver bounds causes unexpected H5Fopen failures. File with non-SWMR-write access can now be opened without regard for superblock version. Due to the fix, H5Fstart_swmr_write() also needs to be modified as well as the tests for libver bounds. The "RFC: Setting Bounds for Object Creation in HDF5 1.10.0" is also updated to reflect the changes. * Fix c++ libver bound test failure.
…roup#4954) When we initialize the floating-point types at library startup, it's possible to raise floating-point exceptions when we check which things are supported. Normally, we clear these floating-point exceptions via feclearexcept(FE_INVALID), but FE_INVALID may not be present on all systems. Specifically, this was reported as being a problem when using Emscripten 3.1.68 to compile HDF5 1.14.5 to WebAssembly. We've added an #ifdef FE_INVALID block around the exception clearing code to correct this. Fixes HDFGroup#4952
…ion compare (HDFGroup#4955) * Rerun dmg on failure - correct ABI version compare * Remove unneeded dmg step
* Do not package debug builds * Do not try to upload with debug builds
* corrected Fortran docs for hyperslab selection * updated hyperslab op doc
Previously was hardcoding `-lzlib-static` which will result in the wrong linker flags when built with system zlib. It looks like there was logic to figure out the library name but the resulting `libname` was never used.
* Remove TRUE and FALSE from H5private.h * Replace hbool_t with bool in test code
__int64 raises warnings when building with clang
Ignores some of the older Autotools platform files, since the Autotools will be dropped in the next major release (and we don't have compilers on which to test, anyway). Also drops support for the old, non-compliant MSVC preprocessor.
The high-level GIF tools, h52gif and gif2h5, have unfixed CVE issues (with no proof-of-concept files). They are not critical tools, are not well maintained, and are an odd fit for building with the library. Because of this, they have been removed. We may move them to a separate repository in the future.
This is where most people will expect to find license information. The COPYING_LBNL_HDF5 file has also been renamed to LICENSE_LBNL_HDF5. The licenses are unchanged.
The CMake compiler checks skip checking for things like __attribute__() on Windows. Now that Visual Studio can use clang, we should be checking for this, even on non-MinGW Windows.
Solaris Studio hasn't been updated in almost a decade and the last version (12.4, circa 2015) doesn't seem to fully support C11. This PR removes some work-arounds for things like __attribute__() support.
These files are infrequently updated and generating them adds an
annoying dependency on Perl. We're checking them in and will
probably add a GitHub action to check if anything is stale
when creating a PR.
Adds:
* H5Edefin.h
* H5Einit.h
* H5Emajdef.h
* H5Emindef.h
* H5Epubgen.h
* H5Eterm.h
* H5overflow.h
* H5version.h
This was an unsupported build script to make building the library with CMake look like building it with the Autotools. It hasn't been maintained in a long time and we've had it marked as deprecated for years.
…p#4998) * Add warnings as errors workflow for cmake * Add spc par workflow * Add workflow call * Add parallel special
PR HDFGroup#4968 fixes a bug that causes the Julia CI to fail due to buggy HDF5 behavior. The Julia CI will need to be updated to properly test the fixed feature.
Makes it more like the rest of the library. Also simplifies some string copying.
* Rename functions that create AWS strings to include _make_aws_ in the name * Separate out the test-only load AWS credentials function
* Exclude test files from coverage command * Exlude compression sources
- Added \since to enum constants added in 1.8.x versions - Removed unnecessary continuation backslashes in doxygen comments
Also renames the curl callback
* Changed comment style to avoid long line issue. * Update H5Mpublic.h for clang format --------- Co-authored-by: Dana Robinson <[email protected]>
The AWS configuration and authorization setup code needs to be consolidated into one location in order to check AWS environment variables and configuration files as well as fapl parameters. This changeset pushes some stragglers into the s3comms code. Also includes some cleanup, like removing useless macros, making the s3comms functions package functions, and renames things for symmetry and readability.
Fix usages of stack variables after function return by removing extraneous H5CX_push/pop operations and hoisting a stack variable to a higher scope
…eature/sparse_data
fortnern
requested review from
jhendersonHDF,
byrnHDF,
derobins,
brtnfld,
epourmal,
lrknox,
qkoziol,
vchoi-hdfgroup,
bmribler,
glennsong09 and
mattjala
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.