Fix error in H5Ddebug() #5299
Merged
Fix error in H5Ddebug() #5299
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
systems. Add test case for v1 b-trees.
fortnern
requested review from
lrknox,
derobins,
byrnHDF,
jhendersonHDF,
qkoziol,
vchoi-hdfgroup,
bmribler,
glennsong09,
mattjala and
brtnfld
as code owners
mattjala
previously approved these changes
Feb 7, 2025
|
Hmm I guess we changed the settings so we need to re-review after changes? Sorry Matt. Only thing I did was add a note to RELEASE.txt. |
mattjala
approved these changes
Feb 7, 2025
qkoziol
approved these changes
Feb 7, 2025
|
Looks like the mirror VFD tests are failing due to an old issue that I thought was fixed at this point. |
Test passed on retry. We should keep an eye out for it, but I'll go ahead and merge the PR |
byrnHDF
pushed a commit
to byrnHDF/hdf5
that referenced
this pull request
Feb 10, 2025
* Fix error in H5Ddebug(). Add h5ls test cases. * Committing clang-format changes * Fix cmake (hopefully) * Fix cmake again (hopefully) * Fix issue with modification times showing up differently on different systems. Add test case for v1 b-trees. * Add cmake for new tests * Add RELEASE.txt entry --------- Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
H5Ddebug() currently does not tag the dataset object header for the metadata cache, causing attempts to iterate over the index (which may require protecting a piece of metadata) to throw an error. This was causing h5ls -va to silently fail to print any chunk addresses. Added tagging and test cases for h5ls to prevent regression.