multi-image support for llama3.2 #705
Open
+78
−23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yma11
requested review from
kzawora-intel,
madamczykhabana,
michalkuligowski,
mgawarkiewicz,
vivekgoe and
afierka-intel
as code owners
yma11
force-pushed
the
multi-image
branch
3 times, most recently
from
8477d17 to
08541ff
Compare
|
@kdamaszk @michalkuligowski @kzawora-intel, can you help review on this PR? Already tested on 11B and 90B. |
kdamaszk
reviewed
Jan 24, 2025
kdamaszk
reviewed
Jan 24, 2025
yma11
force-pushed
the
multi-image
branch
3 times, most recently
from
c9bfe70 to
7223fb8
Compare
kdamaszk
reviewed
Jan 27, 2025
|
@yma11 I observed accuracy regression on MMMU val dataset and LLama 3.2 11B Vision Instruct. Let's sync offline |
yma11
force-pushed
the
multi-image
branch
2 times, most recently
from
69411f3 to
0c2759e
Compare
|
@PatrykWo please review |
|
@kdamaszk I see some errors in CI. Please rebase with the base branch so you are up to date and we can confirm that new changes does not influence the PR. |
Signed-off-by: yan ma <[email protected]>
Signed-off-by: yan ma <[email protected]>
Signed-off-by: yan ma <[email protected]>
jkaniecki
requested changes
Feb 12, 2025
| is_causal=False) | ||
| output = output.permute(2, 0, 1, 3).reshape( | ||
| q_len, self.num_local_heads * self.head_dim) | ||
| return output |
There was a problem hiding this comment.
@yma11 This PR works fine but using Fused SDPA in cross attetnion results in worse accuracy. We should better keep F.scaled_dot_product_attention here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.