Skip to content

Commit

Permalink
diagnostic: fix XDG_DATA_DIRS check
Browse files Browse the repository at this point in the history
Pass `XDG_DATA_DIRS` through `bin/brew` so that it can be checked.
  • Loading branch information
gromgit authored and MikeMcQuaid committed Aug 5, 2024
1 parent 78132b1 commit 3eaebdc
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 2 deletions.
4 changes: 2 additions & 2 deletions Library/Homebrew/extend/os/linux/diagnostic.rb
Original file line number Diff line number Diff line change
Expand Up @@ -60,8 +60,8 @@ def check_tmpdir_executable
end

def check_xdg_data_dirs
xdg_data_dirs = ENV.fetch("XDG_DATA_DIRS", nil)
return if xdg_data_dirs.blank? || xdg_data_dirs.split("/").include?(HOMEBREW_PREFIX/"share")
xdg_data_dirs = ENV.fetch("HOMEBREW_XDG_DATA_DIRS", nil)

Check warning on line 63 in Library/Homebrew/extend/os/linux/diagnostic.rb

View check run for this annotation

Codecov / codecov/patch

Library/Homebrew/extend/os/linux/diagnostic.rb#L63

Added line #L63 was not covered by tests
return if xdg_data_dirs.blank? || xdg_data_dirs.split(":").include?(HOMEBREW_PREFIX/"share")

<<~EOS
Homebrew's share was not found in your XDG_DATA_DIRS but you have
Expand Down
1 change: 1 addition & 0 deletions bin/brew
Original file line number Diff line number Diff line change
Expand Up @@ -185,6 +185,7 @@ USED_BY_HOMEBREW_VARS=(
SUDO_USER
TMUX
XDG_CACHE_HOME
XDG_DATA_DIRS
XDG_RUNTIME_DIR
ZDOTDIR
)
Expand Down

0 comments on commit 3eaebdc

Please sign in to comment.