Merge pull request #18631 from Homebrew/sf-fixes

rubocops/shared/url_helper: tweak SourceForge handling
Homebrew · Oct 24, 2024 · 5538282 · 5538282
2 parents 3b52a46 + 3292dc3
commit 5538282
Showing 1 changed file with 7 additions and 3 deletions.
diff --git a/Library/Homebrew/rubocops/shared/url_helper.rb b/Library/Homebrew/rubocops/shared/url_helper.rb
@@ -97,7 +97,8 @@ def audit_url(type, urls, mirrors, livecheck_url: false)
                                                %r{^http://hackage\.haskell\.org/},
                                                %r{^http://(?:[^/]*\.)?archive\.org},
                                                %r{^http://(?:[^/]*\.)?freedesktop\.org},
-                                               %r{^http://(?:[^/]*\.)?mirrorservice\.org/}])
+                                               %r{^http://(?:[^/]*\.)?mirrorservice\.org/},
+                                               %r{^http://downloads?\.sourceforge\.net/}])
         audit_urls(urls, http_to_https_patterns) do |_, url, index|
           # It's fine to have a plain HTTP mirror further down the mirror list.
           https_url = url.dup.insert(4, "s")
@@ -153,7 +154,7 @@ def audit_url(type, urls, mirrors, livecheck_url: false)
 
           problem "Don't use /download in SourceForge urls (url is #{url})." if url.end_with?("/download")
 
-          if url.match?(%r{^https?://sourceforge\.}) && url != livecheck_url
+          if url.match?(%r{^https?://(sourceforge|sf)\.}) && url != livecheck_url
             problem "Use https://downloads.sourceforge.net to get geolocation (url is #{url})."
           end
 
@@ -165,7 +166,10 @@ def audit_url(type, urls, mirrors, livecheck_url: false)
             problem "Don't use specific dl mirrors in SourceForge urls (url is #{url})."
           end
 
-          problem "Please use https:// for #{url}" if url.start_with? "http://downloads"
+          # sf.net does HTTPS -> HTTP redirects.
+          if url.match?(%r{^https?://downloads?\.sf\.net})
+            problem "Use https://downloads.sourceforge.net instead of downloads.sf.net (url is #{url})"
+          end
         end
 
         # Debian has an abundance of secure mirrors. Let's not pluck the insecure