Skip to content

Commit

Permalink
Merge pull request #18548 from Homebrew/unpack_strategy-group-fix
Browse files Browse the repository at this point in the history
unpack_strategy: fix unpack Dir.mktmpdir group
  • Loading branch information
Bo98 authored Oct 14, 2024
2 parents d1e539c + f223fef commit 7067260
Showing 1 changed file with 21 additions and 0 deletions.
21 changes: 21 additions & 0 deletions Library/Homebrew/unpack_strategy.rb
Original file line number Diff line number Diff line change
Expand Up @@ -160,6 +160,27 @@ def extract_nestedly(to: nil, basename: nil, verbose: false, prioritize_extensio
Dir.mktmpdir("homebrew-unpack", HOMEBREW_TEMP) do |tmp_unpack_dir|
tmp_unpack_dir = Pathname(tmp_unpack_dir)

# Make sure files inside the temporary directory have the same group as the brew instance.
#
# @see https://github.com/Homebrew/brew/blob/4.4.0/Library/Homebrew/mktemp.rb#L57-L72
group_id = if HOMEBREW_BREW_FILE.grpowned?
HOMEBREW_BREW_FILE.stat.gid
else
Process.gid
end
begin
tmp_unpack_dir.chown(nil, group_id)
rescue Errno::EPERM
require "etc"
group_name = begin
Etc.getgrgid(group_id)&.name
rescue ArgumentError
# Cover for misconfigured NSS setups
nil
end
opoo "Failed setting group \"#{group_name || group_id}\" on #{tmp_unpack_dir}"
end

extract(to: tmp_unpack_dir, basename:, verbose:)

children = tmp_unpack_dir.children
Expand Down

0 comments on commit 7067260

Please sign in to comment.