Skip to content

Commit

Permalink
Disable Naming/BlockForwarding cop as it breaks Sorbet
Browse files Browse the repository at this point in the history
- I'm sure there is a solution somewhere, but I couldn't find one.
- Basically Sorbet runtime complains about missing params in sigs, since
  `&block` turns to `&` with the autocorrections for this cop and that's
  not defineable in the `params` part of the Sorbet signature?
  • Loading branch information
issyl0 authored Dec 14, 2023
1 parent 74d8a9c commit 7b82b69
Showing 1 changed file with 5 additions and 1 deletion.
6 changes: 5 additions & 1 deletion Library/.rubocop.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ inherit_mode:
- Exclude

AllCops:
TargetRubyVersion: 2.6
TargetRubyVersion: 3.1
ActiveSupportExtensionsEnabled: true
NewCops: enable
Include:
Expand Down Expand Up @@ -154,6 +154,10 @@ Lint/UnusedMethodArgument:
Metrics:
Enabled: false

# This is a new cop for Ruby 3.1, but using it Sorbet complains about missing params in sigs.
Naming/BlockForwarding:
Enabled: false

# Allow dashes in filenames.
Naming/FileName:
Regex: !ruby/regexp /^[\w\@\-\+\.]+(\.rb)?$/
Expand Down

0 comments on commit 7b82b69

Please sign in to comment.