os/mac/diagnostic: fix OpenCore check

Fixes #18763.
Homebrew · Nov 13, 2024 · 854fc16 · 854fc16
1 parent b421c2f
commit 854fc16
Showing 1 changed file with 10 additions and 5 deletions.
diff --git a/Library/Homebrew/extend/os/mac/diagnostic.rb b/Library/Homebrew/extend/os/mac/diagnostic.rb
@@ -129,11 +129,16 @@ def check_for_unsupported_macos
         end
 
         def check_for_opencore
-          has_opencore =
-            File.exist?("/Library/PrivilegedHelperTools/com.dortania.opencore-legacy-patcher.privileged-helper")
-          has_opencore ||= File.exist?("/Library/Application Support/Dortania/OpenCore-Patcher.app")
-          has_opencore ||= MacOS.pkgutil_info("com.dortania.opencore-legacy-patcher").present?
-          return unless has_opencore
+          return if ::Hardware::CPU.physical_cpu_arm64?
+
+          # https://dortania.github.io/OpenCore-Legacy-Patcher/UPDATE.html#checking-oclp-and-opencore-versions
+          begin
+            opencore_version = Utils.safe_popen_read("/usr/sbin/nvram",
+                                                     "4D1FDA02-38C7-4A6A-9CC6-4BCCA8B30102:opencore-version")
+            return if opencore_version.blank?
+          rescue ErrorDuringExecution
+            return
+          end
 
           <<~EOS
             You have installed macOS using OpenCore Legacy Patcher.