Merge pull request #17377 from samford/cask-audit-rework-tmpdir-removal

cask/audit: Rework tmpdir removal
Homebrew · May 27, 2024 · 92adf6a · 92adf6a
2 parents 44d0d64 + e2220ec
commit 92adf6a
Showing 1 changed file with 6 additions and 6 deletions.
diff --git a/Library/Homebrew/cask/audit.rb b/Library/Homebrew/cask/audit.rb
@@ -47,12 +47,6 @@ def initialize(
       @token_conflicts = token_conflicts
       @only = only || []
       @except = except || []
-
-      # Clean up `#extract_artifacts` tmp dir when Audit object is destroyed
-      ObjectSpace.define_finalizer(
-        self,
-        proc { FileUtils.remove_entry(@tmpdir) if @tmpdir },
-      )
     end
 
     def run!
@@ -540,6 +534,12 @@ def extract_artifacts
 
       @tmpdir ||= Pathname(Dir.mktmpdir("cask-audit", HOMEBREW_TEMP))
 
+      # Clean up tmp dir when @tmpdir object is destroyed
+      ObjectSpace.define_finalizer(
+        @tmpdir,
+        proc { FileUtils.remove_entry(@tmpdir) },
+      )
+
       ohai "Downloading and extracting artifacts"
 
       downloaded_path = download.fetch