Merge pull request #17252 from bevanjkay/extract_plist_url

extract_plist: fix passing an alternative url
Homebrew · May 8, 2024 · 9bf7734 · 9bf7734
2 parents 41cbfc3 + 6c90e65
commit 9bf7734
Showing 1 changed file with 2 additions and 5 deletions.
diff --git a/Library/Homebrew/livecheck/livecheck.rb b/Library/Homebrew/livecheck/livecheck.rb
@@ -762,11 +762,8 @@ def latest_version(
         # in the strategy's `#find_versions` method once we figure out why
         # `strategy.method(:find_versions).parameters` isn't working as
         # expected.
-        if strategy_name == "ExtractPlist"
-          strategy_args[:cask] = cask if cask.present?
-        else
-          strategy_args[:url] = url
-        end
+        strategy_args[:cask] = cask if strategy_name == "ExtractPlist" && cask.present?
+        strategy_args[:url] = url
         strategy_args.compact!
 
         strategy_data = strategy.find_versions(**strategy_args, &livecheck_strategy_block)