Skip to content

Commit

Permalink
github_runner_matrix: extend timeout for dependent tests on arm64
Browse files Browse the repository at this point in the history
We give our ARM runners half the timeout of the Intel runners because
the ARM runners are faster. However, this is no longer true for
dependent testing because we test recursive dependents on ARM but skip
them on Intel.

This means that we can often hit the timeout on ARM but have all jobs
finish on Intel. We can re-run these with the long build label, but
that's a bit wasteful of our limited long build slots.

Instead, let's just use the same timeout value across ARM and Intel
runners when testing dependents: 2 hours.
  • Loading branch information
carlocab committed Nov 1, 2024
1 parent ad98e30 commit a1853fc
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions Library/Homebrew/github_runner_matrix.rb
Original file line number Diff line number Diff line change
Expand Up @@ -169,6 +169,8 @@ def generate_runners!
["#{version}-arm64", runner_timeout]
end

# We test recursive dependents on ARM macOS, so they can be slower than our Intel runners.
timeout *= 2 if @dependent_matrix && timeout < GITHUB_ACTIONS_RUNNER_TIMEOUT
spec = MacOSRunnerSpec.new(
name: "macOS #{version}-arm64",
runner:,
Expand Down

0 comments on commit a1853fc

Please sign in to comment.