Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-authored-by: Eric Knibbe <[email protected]>
  • Loading branch information
ZhongRuoyu and EricFromCanada authored Nov 13, 2024
1 parent 13265ca commit a525ce0
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions Library/Homebrew/extend/os/mac/diagnostic.rb
Original file line number Diff line number Diff line change
Expand Up @@ -135,14 +135,14 @@ def check_for_opencore
# https://dortania.github.io/OpenCore-Legacy-Patcher/UPDATE.html#checking-oclp-and-opencore-versions
begin
opencore_version = Utils.safe_popen_read("/usr/sbin/nvram",

Check warning on line 137 in Library/Homebrew/extend/os/mac/diagnostic.rb

View check run for this annotation

Codecov / codecov/patch

Library/Homebrew/extend/os/mac/diagnostic.rb#L137

Added line #L137 was not covered by tests
"4D1FDA02-38C7-4A6A-9CC6-4BCCA8B30102:opencore-version")
"4D1FDA02-38C7-4A6A-9CC6-4BCCA8B30102:opencore-version").split[1]
return if opencore_version.blank?
rescue ErrorDuringExecution
return

Check warning on line 141 in Library/Homebrew/extend/os/mac/diagnostic.rb

View check run for this annotation

Codecov / codecov/patch

Library/Homebrew/extend/os/mac/diagnostic.rb#L141

Added line #L141 was not covered by tests
end

<<~EOS
You have installed macOS using OpenCore Legacy Patcher.
You have booted macOS using OpenCore Legacy Patcher.
We do not provide support for this configuration.
#{please_create_pull_requests}
EOS
Expand Down

0 comments on commit a525ce0

Please sign in to comment.