fix

Homebrew · Jan 19, 2024 · b1820b7 · b1820b7
1 parent cc2750d
commit b1820b7
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/Library/.rubocop.yml b/Library/.rubocop.yml
@@ -358,6 +358,7 @@ Style/InverseMethods:
     - "Homebrew/rubocops/**/*.rb"
     - "Homebrew/sorbet/tapioca/require.rb"
     - "Homebrew/standalone/init.rb"
+    - "Homebrew/utils/gems.rb"
   InverseMethods:
     :include?: :exclude?
     :exclude?: :include?
@@ -369,6 +370,7 @@ Style/InvertibleUnlessCondition:
     - "Homebrew/rubocops/**/*.rb"
     - "Homebrew/sorbet/tapioca/require.rb"
     - "Homebrew/standalone/init.rb"
+    - "Homebrew/utils/gems.rb"
   InverseMethods:
     # Favor `if a != b` over `unless a == b`
     :==: :!=

diff --git a/Library/Homebrew/utils/gems.rb b/Library/Homebrew/utils/gems.rb
@@ -105,8 +105,8 @@ def setup_gem_environment!(setup_path: true)
 
     # Add necessary Ruby and Gem binary directories to `PATH`.
     paths = ENV.fetch("PATH").split(":")
-    paths.unshift(ruby_bindir) if paths.exclude?(ruby_bindir)
-    paths.unshift(Gem.bindir) if paths.exclude?(Gem.bindir)
+    paths.unshift(ruby_bindir) unless paths.include?(ruby_bindir)
+    paths.unshift(Gem.bindir) unless paths.include?(Gem.bindir)
     ENV["PATH"] = paths.compact.join(":")
 
     # Set envs so the above binaries can be invoked.
@@ -135,7 +135,7 @@ def install_gem!(name, version: nil, setup_gem_environment: true)
     specs.each do |spec|
       spec.require_paths.each do |path|
         full_path = File.join(spec.full_gem_path, path)
-        $LOAD_PATH.unshift full_path if $LOAD_PATH.exclude?(full_path)
+        $LOAD_PATH.unshift full_path unless $LOAD_PATH.include?(full_path)
       end
     end
   rescue Gem::UnsatisfiableDependencyError