Skip to content

Commit

Permalink
switch from default to optional
Browse files Browse the repository at this point in the history
default="" is better expressed as optional

Co-authored-by: Solomon Hykes <[email protected]>
  • Loading branch information
marcosnils and shykes authored Jun 21, 2024
1 parent 5aab7bc commit be2d9f4
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions dagger/main.go
Original file line number Diff line number Diff line change
Expand Up @@ -115,9 +115,9 @@ func (m *Brew) Test(ctx context.Context,
// runs brew test-bot against all versions
func (m *Brew) TestAll(ctx context.Context,
src *Directory,
// +default=""
// +optional
commitSHA string,
// +default=""
// +optional
brewVersion string,
) error {
eg := errgroup.Group{}
Expand Down

0 comments on commit be2d9f4

Please sign in to comment.