Apply suggestions from code review

Co-authored-by: Mike McQuaid <[email protected]>
Homebrew · Jun 29, 2024 · d84246c · d84246c
1 parent 622cbdc
commit d84246c
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 5 deletions.
diff --git a/Library/Homebrew/descriptions.rb b/Library/Homebrew/descriptions.rb
@@ -8,9 +8,10 @@
 # Helper class for printing and searching descriptions.
 class Descriptions
   # Given a regex, find all formulae whose specified fields contain a match.
-  def self.search(string_or_regex, field, cache_store, eval_all = Homebrew::EnvConfig.eval_all?)
-    # allow searching a simple hash, not only cache_store objects
-    cache_store.populate_if_empty!(eval_all:) if cache_store.methods.include?(:populate_if_empty!)
+  def self.search(string_or_regex, field, cache_store,
+                  eval_all = Homebrew::EnvConfig.eval_all?, cache_store_hash: false)
+
+    cache_store.populate_if_empty!(eval_all:) unless cache_store_hash
 
     results = case field
     when :name

diff --git a/Library/Homebrew/search.rb b/Library/Homebrew/search.rb
@@ -29,7 +29,7 @@ def self.search_descriptions(string_or_regex, args, search_type: :desc)
           end
         else
           descriptions = Homebrew::API::Formula.all_formulae.transform_values { |data| data["desc"] }
-          Descriptions.search(string_or_regex, search_type, descriptions, eval_all).print
+          Descriptions.search(string_or_regex, search_type, descriptions, eval_all, cache_store_hash: true).print
         end
       end
       return if !args.cask? && !both
@@ -44,7 +44,7 @@ def self.search_descriptions(string_or_regex, args, search_type: :desc)
         end
       else
         descriptions = Homebrew::API::Cask.all_casks.transform_values { |data| data["desc"] }
-        Descriptions.search(string_or_regex, search_type, descriptions, eval_all).print
+        Descriptions.search(string_or_regex, search_type, descriptions, eval_all, cache_store_hash: true).print
       end
     end