Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump: add arch-specific support #15763

Merged
merged 2 commits into from
Aug 4, 2023

Conversation

razvanazamfirei
Copy link
Member

@razvanazamfirei razvanazamfirei commented Jul 26, 2023

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

This is the bump-specific part of #15611 and a continuation of #15725.

The bump command has been refactored to include architecture-specific livechecks. By simulating different architectures, bump now returns architecture-specific results in a unified structure. This structure is leveraged in the retrieve_and_display_info_and_open_pr method to display livecheck results and pass updated versions to bump-cask-pr.

In addition, an issue with handling duplicate PRs has been addressed. Previously, bump returned Duplicate PRs should not be opened. Use --force to override this error. when duplicate PRs were identified. This wasn't actually implemented. The bump command now passes the --force switch to brew-#{type}-pr when appropriate.

While primarily focusing on the bump command, these changes also impact formulae. I've tried to preserve existing functionality and welcome any feedback on potential areas overlooked.

This will resolve #15167.

I also welcome any feedback in terms of displaying the information. The current format (see below) doesn't look great when the versions get long.

❯ brew bump multiviewer-for-f1
==> multiviewer-for-f1
Current cask version:     arm: 1.24.0,116220388 | intel: 1.24.0,116220919
Latest livecheck version: arm: 1.24.1,117979343 | intel: 1.24.1,117980427
Latest Repology version:  1.24.1
Open pull requests:       none
Closed pull requests:     none

@MikeMcQuaid
Copy link
Member

I also welcome any feedback in terms of displaying the information. The current format (see below) doesn't look great when the versions get long.

I think it'd be nice to have ARM and Intel versions on separate lines.

Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code makes sense to me! Would be nice to improve version output, as mentioned.

Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks again @razvanazamfirei!

@MikeMcQuaid MikeMcQuaid merged commit 0e09851 into Homebrew:master Aug 4, 2023
24 checks passed
@razvanazamfirei razvanazamfirei deleted the bump-add-arch-support branch August 4, 2023 14:15
@github-actions github-actions bot added the outdated PR was locked due to age label Sep 4, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

brew bump-cask-pr Multi-arch casks only updating one arch
2 participants