Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow hiding new/deleted formula/cask sections on update #15836

Merged
merged 1 commit into from
Aug 7, 2023

Conversation

eugenesvk
Copy link
Contributor

@eugenesvk eugenesvk commented Aug 7, 2023

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally? (see errors below)

This information is mostly noise, so added an env var to allow to silence it

closes https://github.com/orgs/Homebrew/discussions/4590

Copy link

@tyrann0us tyrann0us left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this! Does it also make sense to make disabling the deleted formulae/casks lists possible?

docs/Manpage.md Outdated Show resolved Hide resolved
@eugenesvk eugenesvk changed the title Allow hiding new foruma/cask sections on update Allow hiding new forum/cask sections on update Aug 7, 2023
@eugenesvk
Copy link
Contributor Author

as far as I undersand, deleted section reports only those formulas that the user has installed, so it's more relevant information (unless HOMEBREW_UPDATE_REPORT_ALL_FORMULAE is set)

But maybe it still makes sense to silence those as well, so also added that option

@eugenesvk eugenesvk changed the title Allow hiding new forum/cask sections on update Allow hiding new/deleted formula/cask sections on update Aug 7, 2023
@eugenesvk eugenesvk force-pushed the hide_section branch 2 times, most recently from 0f55d4b to 47d4c3c Compare August 7, 2023 12:15
Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@eugenesvk Thanks for the PR!

Would a single variable that hid both meet both your needs?

@eugenesvk @tyrann0us

Library/Homebrew/cmd/update-report.rb Outdated Show resolved Hide resolved
docs/Manpage.md Outdated Show resolved Hide resolved
@MikeMcQuaid
Copy link
Member

Does it also make sense to make disabling the deleted formulae/casks lists possible?

@tyrann0us Can you explain why you want to hide this? As @eugenesvk said, it's only those that you have installed so seems like pretty important information.

@eugenesvk
Copy link
Contributor Author

A single var would be fine for me, just created 2 in case someone has more refined silencing tastes :)

@tyrann0us
Copy link

Hi @MikeMcQuaid,

Would a single variable that hid both meet both your needs?

Yes, that would work fine for me. I'd actually prefer that.

Can you explain why you want to hide this? As @eugenesvk said, it's only those that you have installed so seems like pretty important information.

TBH, I wasn't aware that this section only lists deleted formulae/casks that the user has installed. 🙈
Totally agree that this is important information, so please disregard that comment.

Thanks!

@MikeMcQuaid
Copy link
Member

@eugenesvk Thanks. Do you personally want deleted formulae hidden or just new ones?

TBH, I wasn't aware that this section only lists deleted formulae/casks that the user has installed. 🙈

Thanks. Could clarify the title of that section perhaps 👍🏻

@eugenesvk
Copy link
Contributor Author

Do you personally want deleted formulae hidden or just new ones?

Do you personally want deleted formulae hidden or just new ones?

No, to me it's important to know of some formula I have disappears. Personally I'm fine having a single var that only suppresses updates, and it seems you and @tyrann0us too, so will change to 1

Library/Homebrew/env_config.rb Outdated Show resolved Hide resolved
Library/Homebrew/cmd/update-report.rb Outdated Show resolved Hide resolved
Library/Homebrew/cmd/update-report.rb Outdated Show resolved Hide resolved
@eugenesvk eugenesvk force-pushed the hide_section branch 3 times, most recently from 8e0d85b to a3c8004 Compare August 7, 2023 13:34
Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for your repeated contribution! Without people like you submitting PRs we couldn't run this project. You rock, @eugenesvk!

@MikeMcQuaid MikeMcQuaid merged commit 7ed11b2 into Homebrew:master Aug 7, 2023
24 checks passed
@eugenesvk eugenesvk deleted the hide_section branch August 7, 2023 16:11
@github-actions github-actions bot added the outdated PR was locked due to age label Sep 7, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants