-
-
Notifications
You must be signed in to change notification settings - Fork 9.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow hiding new/deleted formula/cask sections on update #15836
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this! Does it also make sense to make disabling the deleted formulae/casks lists possible?
as far as I undersand, deleted section reports only those formulas that the user has installed, so it's more relevant information (unless But maybe it still makes sense to silence those as well, so also added that option |
0f55d4b
to
47d4c3c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@eugenesvk Thanks for the PR!
Would a single variable that hid both meet both your needs?
@tyrann0us Can you explain why you want to hide this? As @eugenesvk said, it's only those that you have installed so seems like pretty important information. |
A single var would be fine for me, just created 2 in case someone has more refined silencing tastes :) |
Hi @MikeMcQuaid,
Yes, that would work fine for me. I'd actually prefer that.
TBH, I wasn't aware that this section only lists deleted formulae/casks that the user has installed. 🙈 Thanks! |
@eugenesvk Thanks. Do you personally want deleted formulae hidden or just new ones?
Thanks. Could clarify the title of that section perhaps 👍🏻 |
Do you personally want deleted formulae hidden or just new ones? No, to me it's important to know of some formula I have disappears. Personally I'm fine having a single var that only suppresses updates, and it seems you and @tyrann0us too, so will change to 1 |
8e0d85b
to
a3c8004
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks so much for your repeated contribution! Without people like you submitting PRs we couldn't run this project. You rock, @eugenesvk!
brew style
with your changes locally?brew typecheck
with your changes locally?brew tests
with your changes locally? (see errors below)This information is mostly noise, so added an env var to allow to silence it
closes https://github.com/orgs/Homebrew/discussions/4590