Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps): bump rubocop-sorbet from 0.7.0 to 0.7.3 in /Library/Homebrew #15883

Merged

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Aug 17, 2023

Bumps rubocop-sorbet from 0.7.0 to 0.7.3.

Release notes

Sourced from rubocop-sorbet's releases.

v0.7.3

What's Changed

🐛 Bug Fixes

Full Changelog: Shopify/rubocop-sorbet@v0.7.2...v0.7.3

v0.7.2

What's Changed

🐛 Bug Fixes

New Contributors

Full Changelog: Shopify/rubocop-sorbet@v0.7.1...v0.7.2

v0.7.1

⚠️ This version drops support for Ruby 2.5 and 2.6. The gem should still be usable with those Ruby versions, but we will make no attempt at making it compatible nor will we be testing it against those versions going forward.

What's Changed

✨ Enhancements

🐛 Bug Fixes

🛠 Other Changes

... (truncated)

Commits
  • 3cf5b67 Bump version to v0.7.3
  • 16e1ee7 Merge pull request #173 from Shopify/ko-at/undefined-method
  • e95a16e Support block syntax in AllowIncompatibleOverride
  • 7a42d25 Bump version to v0.7.2
  • c2fc705 Merge pull request #170 from jakebrady5/jakebrady5/sigil-regex
  • f92d3ba fix trailing whitespace
  • 817a6ab use [[:blank:]] over \s
  • e2ffb34 match SIGIL_REGEX behavior to sorbet sigil parsing
  • e908bac Bump version to v0.7.1
  • 5bc72c7 Add comment explaining non-standard memoization pattern
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added dependencies Bumping Gemfile dependencies ruby Pull requests that update Ruby code labels Aug 17, 2023
@MikeMcQuaid
Copy link
Member

@Bo98 any idea what's going on here?

@Bo98
Copy link
Member

Bo98 commented Aug 21, 2023

Technically speaking, it's somewhat an upstream bug:

def read_sorbet_static_version_from_bundler_lock_file
  require "bundler"
  ::Bundler.locked_gems.specs.find { |spec| spec.name == "sorbet-static" }&.version
rescue LoadError, Bundler::GemfileNotFound
  nil
end

In the event of a LoadError, it will error in the rescue clause because it references Bundler which of course hasn't actually loaded...

Though with that said, we probably do want to add Bundler to the load path to enable the logic this is trying to do. The setup.rb file currently does not do this. Homebrew.install_bundler! does, which we could perhaps call in rubocop.rb given it is probably already installed and will probably only do load path adjustments.

Alternatively, we can do it ourselves given we have HOMEBREW_BUNDLER_VERSION.

@MikeMcQuaid
Copy link
Member

Though with that said, we probably do want to add Bundler to the load path to enable the logic this is trying to do. The setup.rb file currently does not do this. Homebrew.install_bundler! does, which we could perhaps call in rubocop.rb given it is probably already installed and will probably only do load path adjustments.

Alternatively, we can do it ourselves given we have HOMEBREW_BUNDLER_VERSION.

Ah, yeh, either of these sounds fine to me.

@Bo98
Copy link
Member

Bo98 commented Aug 21, 2023

For example, we could have:

$LOAD_PATH.unshift "#{HOMEBREW_LIBRARY_PATH}/vendor/#{RUBY_ENGINE}/#{Gem.ruby_api_version}/gems/bundler-#{HOMEBREW_BUNDLER_VERSION}/lib/bundler"

in load_path.rb after we do bundler/setup (untested).

@github-actions
Copy link

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@github-actions github-actions bot added the stale No recent activity label Sep 12, 2023
dependabot bot and others added 3 commits September 13, 2023 14:09
Bumps [rubocop-sorbet](https://github.com/shopify/rubocop-sorbet) from 0.7.0 to 0.7.3.
- [Release notes](https://github.com/shopify/rubocop-sorbet/releases)
- [Commits](Shopify/rubocop-sorbet@v0.7.0...v0.7.3)

---
updated-dependencies:
- dependency-name: rubocop-sorbet
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
@Bo98 Bo98 force-pushed the dependabot/bundler/Library/Homebrew/rubocop-sorbet-0.7.3 branch from e6fb794 to d141ed3 Compare September 13, 2023 13:12
@Bo98 Bo98 force-pushed the dependabot/bundler/Library/Homebrew/rubocop-sorbet-0.7.3 branch from d141ed3 to 4b7eec6 Compare September 13, 2023 13:17
@Bo98 Bo98 removed the stale No recent activity label Sep 13, 2023
@MikeMcQuaid
Copy link
Member

Thanks @Bo98!

@MikeMcQuaid MikeMcQuaid merged commit c953076 into master Sep 13, 2023
31 checks passed
@MikeMcQuaid MikeMcQuaid deleted the dependabot/bundler/Library/Homebrew/rubocop-sorbet-0.7.3 branch September 13, 2023 13:39
@github-actions github-actions bot added the outdated PR was locked due to age label Oct 14, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
dependencies Bumping Gemfile dependencies outdated PR was locked due to age ruby Pull requests that update Ruby code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants