Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: pkg for RHEL #15897

Closed
wants to merge 1 commit into from
Closed

Conversation

SMillerDev
Copy link
Member

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

This builds a package for RHEL to ensure that linuxbrew is installed correctly even without the cURLed script on the homepage

Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work so far! Some questions:

  • does this produce the exact same output as e.g. install.sh? I guess I wonder if we could start unifying some code so that this could e.g. call build and install functions from that script perhaps?
  • is this useful as a standalone package without a RPM repository (or whatever they are called)?

package/homebrew.spec Outdated Show resolved Hide resolved
@SMillerDev
Copy link
Member Author

does this produce the exact same output as e.g. install.sh? I guess I wonder if we could start unifying some code so that this could e.g. call build and install functions from that script perhaps?

It is the goal to make it the same, similar to how the macOS pkg works.

is this useful as a standalone package without a RPM repository (or whatever they are called)?

Yes, although a repo would be even more useful so we can distribute updates like this. But that's out of scope for now.

@SMillerDev SMillerDev force-pushed the feat/package/rpm branch 26 times, most recently from 16c783b to 5ae1d1a Compare August 23, 2023 09:11
@MikeMcQuaid
Copy link
Member

Unsubscribing from thread for now but shout when non-draft/green CI @SMillerDev.

@SMillerDev SMillerDev force-pushed the feat/package/rpm branch 6 times, most recently from 30c74e1 to 4e2d8a4 Compare August 23, 2023 09:35
@SMillerDev
Copy link
Member Author

Error: Need to download https://formulae.brew.sh/api/formula.jws.json but cannot as root! Run brew update without sudo first then try again.

Any suggestions how to fix that one, preferably short of creating a new user in the container to run the whole process under?

@github-actions
Copy link

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@github-actions github-actions bot added the stale No recent activity label Sep 14, 2023
@SMillerDev
Copy link
Member Author

I guess I have to make a user 😞

@github-actions github-actions bot removed the stale No recent activity label Sep 14, 2023
@github-actions
Copy link

github-actions bot commented Oct 6, 2023

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@github-actions github-actions bot added the stale No recent activity label Oct 6, 2023
@SMillerDev
Copy link
Member Author

Still on my todo list, sonoma release got in the way

@github-actions github-actions bot removed the stale No recent activity label Oct 6, 2023
@LecrisUT
Copy link

@SMillerDev Could I make a suggestion for a more modern approach? packit helps maintain both upstream and downstream tasks like building in copr and running upstream tests, and making pull-requests downstream.

@SMillerDev
Copy link
Member Author

@LecrisUT I'm not sure how that would look like for Homebrew, but sure I'd review a PR for it.

@LecrisUT
Copy link

@LecrisUT I'm not sure how that would look like for Homebrew, but sure I'd review a PR for it.

Ok, I've open a quick PR for it in #16164. I haven't addressed the actual design of the .spec file so there are some build issues, but I can come back to it this weekend if needed

@SMillerDev
Copy link
Member Author

Okay, let's continue there

@SMillerDev SMillerDev closed this Oct 30, 2023
@github-actions github-actions bot added the outdated PR was locked due to age label Nov 30, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 30, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants