-
-
Notifications
You must be signed in to change notification settings - Fork 9.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: pkg for RHEL #15897
feat: pkg for RHEL #15897
Conversation
d5e3b77
to
23ec555
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work so far! Some questions:
- does this produce the exact same output as e.g.
install.sh
? I guess I wonder if we could start unifying some code so that this could e.g. callbuild
andinstall
functions from that script perhaps? - is this useful as a standalone package without a RPM repository (or whatever they are called)?
It is the goal to make it the same, similar to how the macOS pkg works.
Yes, although a repo would be even more useful so we can distribute updates like this. But that's out of scope for now. |
16c783b
to
5ae1d1a
Compare
Unsubscribing from thread for now but shout when non-draft/green CI @SMillerDev. |
30c74e1
to
4e2d8a4
Compare
Any suggestions how to fix that one, preferably short of creating a new user in the container to run the whole process under? |
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
I guess I have to make a user 😞 |
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
Still on my todo list, sonoma release got in the way |
4e2d8a4
to
1608174
Compare
@SMillerDev Could I make a suggestion for a more modern approach? |
1608174
to
2fe9d46
Compare
@LecrisUT I'm not sure how that would look like for Homebrew, but sure I'd review a PR for it. |
2fe9d46
to
298f5cb
Compare
Okay, let's continue there |
brew style
with your changes locally?brew typecheck
with your changes locally?brew tests
with your changes locally?This builds a package for RHEL to ensure that linuxbrew is installed correctly even without the cURLed script on the homepage