Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use HOMEBREW_CURLRC in vendor-install #15900

Merged

Conversation

clint-stripe
Copy link
Contributor

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

Following #15853, there is another place we call curl that can also make use of HOMEBREW_CURLRC to set --config. HOMEBREW_ARTIFACT_DOMAIN is used in line 48 here, so the change in Utils::Curl didn't have any effect.

I missed this because I didn't test installing Homebrew from scratch with this set 😅

Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks again @clint-stripe!

@MikeMcQuaid MikeMcQuaid merged commit 3c8b494 into Homebrew:master Aug 23, 2023
24 checks passed
@github-actions github-actions bot added the outdated PR was locked due to age label Sep 23, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants