Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev-cmd/contributions: usability/performance improvements. #15923

Merged
merged 1 commit into from
Aug 30, 2023
Merged

dev-cmd/contributions: usability/performance improvements. #15923

merged 1 commit into from
Aug 30, 2023

Conversation

MikeMcQuaid
Copy link
Member

  • more sensible/performant defaults: default to primary repositories only for the last year rather than all repositories forever
  • allow specifying more than one user at a time
  • output the breakdown of contributions without needing --csv
  • add a space before the --csv output
  • consolidate some code
  • avoid counting authored commits twice, to improve performance
  • retry failed GitHub API calls (this happens often when querying all maintainers)
  • stop counting after we find 1000 commits for a given user to avoid excessive API queries/pagination

This was required for me to successfully generate contributions for all active maintainers without error and in a reasonably timely fashion.

Copy link
Member

@issyl0 issyl0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏🏻 I like the limiting commits, we don't need all of them forever.

- more sensible/performant defaults: default to primary repositories
  only for the last year rather than all repositories forever
- allow specifying more than one user at a time
- output the breakdown of contributions without needing `--csv`
- add a space before the `--csv` output
- consolidate some code
- avoid counting authored commits twice, to improve performance
- retry failed GitHub API calls (this happens often when querying all
  maintainers)
- stop counting after we find 1000 commits for a given user to avoid
  excessive API queries/pagination
@MikeMcQuaid MikeMcQuaid merged commit 59cc141 into Homebrew:master Aug 30, 2023
25 checks passed
@MikeMcQuaid MikeMcQuaid deleted the brew_contributions_improvements branch August 30, 2023 14:21
@github-actions github-actions bot added the outdated PR was locked due to age label Sep 30, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 30, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants