Make formula upgrades more liberal based on bottle #15927
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I tried and failed to add a test for this because of how buried it is. It is at least covered by existing tests, though. |
There was a problem hiding this comment.
I'm getting the same type of errors showing up in the tests locally when trying to install packages where one of the dependencies doesn't need to be updated based on the new criteria.
It looks like the UsesFromMacOSDependency#installed? method needs to be updated.
When we're installing a formula from a bottle, we currently always upgrade all dependencies in the dependency tree to be safe. However, if we're installing a bottle and the `runtime_dependencies` within that bottle's tab all have older or equal versions to those already installed: we do not need to upgrade these dependencies. This should help a lot of upgrading a lot of the time, at least for users using bottles (which is the huge majority). The only downside or other noticeable change is that this requires us to download or attempt to download the bottle tab before we compute the dependencies at installation time. Co-authored-by: Kevin <[email protected]>
|
Whoops, sorry for auto-merging the WIP commit 🙈 |
4 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we're installing a formula from a bottle, we currently always upgrade all dependencies in the dependency tree to be safe.
However, if we're installing a bottle and the
runtime_dependencieswithin that bottle's tab all have older or equal versions to those already installed: we do not need to upgrade these dependencies.This should help a lot of upgrading a lot of the time, at least for users using bottles (which is the huge majority).
The only downside or other noticeable change is that this requires us to download or attempt to download the bottle tab before we compute the dependencies at installation time.