-
-
Notifications
You must be signed in to change notification settings - Fork 9.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Further split up Gemfile into groups #15953
Conversation
Can we see some benchmarks of the speed differences here? This seems to add quite a lot of complexity so want to see the differences here. |
Will test when I test #15955, but as is with no changes currently takes 1 minute in our CI and also requires a fully functional compiler with Ruby development headers installed (included with the SDK on macOS at least). Changes here should hopefully reduce that down to a few seconds with zero native builds required. |
Cool, if it works: great, decent speedup. No longer native builds required because they are cached or something else? |
657e262
to
a5ed38d
Compare
Thanks again @Bo98! |
Known disruptive tests have failed for this pull request. Commit SHA: 4ec5f04
|
A full
brew install-bundler-gems
is somewhat slow. This PR splits up the gem groups further to allow faster runs in CI etc, as well as allow a basebrew install-bundler-gems --groups=
only install what we already vendor (roughly). This could be used in future PRs to bootstrap a new Ruby.Draft because this requires #15952.