formula: add global caching for declared_runtime_dependencies
#16008
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I was thinking about doing this recently too though I never followed through with it. I think it's smart to avoid trying to cache them for formula with build options but as you already mention that's relatively rare and not used in core anyway. I see a 10s improvement locally without the installed audit which rarely runs on CI. Good work! |
apainintheneck
approved these changes
Sep 15, 2023
MikeMcQuaid
approved these changes
Sep 15, 2023
7 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This improves
brew audit --except=installed --tap=homebrew/coretimes from ~45s (with #16007 applied) to ~30s.This optimisation is not enabled for formulae with options as I'm not 100% confident caching would behave correctly here. Though that doesn't matter for Homebrew/core, and third-party taps typically are much smaller scale that
brew auditis already quick.