Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make Sonoma supported #16019

Merged
merged 1 commit into from
Sep 25, 2023
Merged

Make Sonoma supported #16019

merged 1 commit into from
Sep 25, 2023

Conversation

fxcoudert
Copy link
Member

@fxcoudert fxcoudert commented Sep 21, 2023 •
edited
Loading

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

macOS Sonoma release will happen on 26 September 2023, in 5 days. We have to switch this on at some point, to be decided below. @Bo98 @MikeMcQuaid

MikeMcQuaid
MikeMcQuaid reviewed Sep 21, 2023
View reviewed changes
Library/Homebrew/brew.sh Show resolved Hide resolved
Library/Homebrew/brew.sh Show resolved Hide resolved
@fxcoudert fxcoudert mentioned this pull request Sep 21, 2023
Merged
@Bo98
Copy link
Member

Bo98 commented Sep 21, 2023 •
edited
Loading

This will immediately drop Big Sur from CI so we should time it so we make a new release soon/immediately after otherwise people will get "no bottle" errors.

MikeMcQuaid
MikeMcQuaid approved these changes Sep 21, 2023
View reviewed changes
Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good for when we're happy to do this.

@Bo98 Bo98 changed the title Make Ventura supported Make Sonoma supported Sep 23, 2023
@p-linnane
Copy link
Member

Can we update the commit to be Make Sonoma supported or something?

@fxcoudert fxcoudert marked this pull request as ready for review September 24, 2023 09:12
@MikeMcQuaid MikeMcQuaid merged commit a8519f7 into Homebrew:master Sep 25, 2023
24 checks passed
@fxcoudert fxcoudert deleted the ventura2 branch September 25, 2023 12:09
@scpeters scpeters mentioned this pull request Sep 26, 2023
Merged
@jeeb jeeb mentioned this pull request Oct 16, 2023
Merged
jeeb added a commit to jeeb/mpv that referenced this pull request Oct 16, 2023
@jeeb
github/workflows: remove macOS 11 build
42594a1 
Homebrew has finally given up supporting macOS 11, and all updated
dependencies are being built locally. Additionally, python3.12 - being
a dependency of libass in Homebrew - seems to completely fail under
cairo's meson usage on macOS 11, even if we let it build.

Thus, finally remove macOS 11 from our maCOS build matrix, leaving
12 and 13.

ref: Homebrew/brew#16019
jeeb added a commit to jeeb/mpv that referenced this pull request Oct 16, 2023
@jeeb
github/workflows: remove macOS 11 build
d2cff50 
Homebrew has finally given up supporting macOS 11, and all updated
dependencies are being built locally. Additionally, python3.12 - being
a dependency of libass in Homebrew - seems to completely fail under
cairo's meson usage on macOS 11, even if we let it build.

Thus, finally remove macOS 11 from our macOS build matrix, leaving
12 and 13.

ref: Homebrew/brew#16019
sfan5 pushed a commit to mpv-player/mpv that referenced this pull request Oct 16, 2023
@jeeb @sfan5
github/workflows: remove macOS 11 build
ad0017f 
Homebrew has finally given up supporting macOS 11, and all updated
dependencies are being built locally. Additionally, python3.12 - being
a dependency of libass in Homebrew - seems to completely fail under
cairo's meson usage on macOS 11, even if we let it build.

Thus, finally remove macOS 11 from our macOS build matrix, leaving
12 and 13.

ref: Homebrew/brew#16019
@github-actions github-actions bot added the outdated PR was locked due to age label Oct 26, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@MikeMcQuaid MikeMcQuaid MikeMcQuaid approved these changes

Assignees
No one assigned
Labels
outdated PR was locked due to age
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@fxcoudert @Bo98 @p-linnane @MikeMcQuaid