Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dev-cmd/edit: Move path specific functions to Pathname #16029

Merged
merged 16 commits into from
Sep 27, 2023
Merged

dev-cmd/edit: Move path specific functions to Pathname #16029

merged 16 commits into from
Sep 27, 2023

Commits on Sep 25, 2023

  1. dev-cmd/edit: Move path specific functions to Pathname

    @abitrolly
    abitrolly committed Sep 25, 2023
    Configuration menu
    Copy the full SHA
    1cbf5ce View commit details
    Browse the repository at this point in the history

  2. Separate logic that shows warning from path detection

    @abitrolly
    abitrolly committed Sep 25, 2023
    Configuration menu
    Copy the full SHA
    eae9567 View commit details
    Browse the repository at this point in the history

  3. Move error reporting logic for absent path to separate method

    @abitrolly
    abitrolly committed Sep 25, 2023
    Configuration menu
    Copy the full SHA
    8f072dc View commit details
    Browse the repository at this point in the history

  4. Check paths exist before brew install warning

    @abitrolly
    abitrolly committed Sep 25, 2023
    Configuration menu
    Copy the full SHA
    a78da3e View commit details
    Browse the repository at this point in the history

  5. Rename fail to more descriptive fail_with_message

    @abitrolly
    abitrolly committed Sep 25, 2023
    Configuration menu
    Copy the full SHA
    63c60d2 View commit details
    Browse the repository at this point in the history

  6. Use regexp interpolation instead of string concat

    @abitrolly
    abitrolly committed Sep 25, 2023
    Configuration menu
    Copy the full SHA
    466055a View commit details
    Browse the repository at this point in the history

  7. Move helper Pathname methods into Refinement 

    https://docs.ruby-lang.org/en/2.4.0/syntax/refinements_rdoc.html
    @abitrolly
    abitrolly committed Sep 25, 2023
    Configuration menu
    Copy the full SHA
    96ca1c5 View commit details
    Browse the repository at this point in the history

  8. Skip backticks when printing env var name

    @abitrolly
    abitrolly committed Sep 25, 2023
    Configuration menu
    Copy the full SHA
    7e835bc View commit details
    Browse the repository at this point in the history

  9. Add proper sig for fail_with_message

    @abitrolly
    abitrolly committed Sep 25, 2023
    Configuration menu
    Copy the full SHA
    cbee941 View commit details
    Browse the repository at this point in the history

  10. Update Library/Homebrew/dev-cmd/edit.rb 

    Co-authored-by: Mike McQuaid <[email protected]>
    @abitrolly @MikeMcQuaid
    abitrolly and MikeMcQuaid authored Sep 25, 2023
    Configuration menu
    Copy the full SHA
    e3c0daf View commit details
    Browse the repository at this point in the history

  11. Move condition in interpolated part into variable

    @abitrolly
    abitrolly committed Sep 25, 2023
    Configuration menu
    Copy the full SHA
    6c7f3eb View commit details
    Browse the repository at this point in the history

  12. Rename refinement

    @abitrolly
    abitrolly committed Sep 25, 2023
    Configuration menu
    Copy the full SHA
    d16e7e1 View commit details
    Browse the repository at this point in the history

Commits on Sep 26, 2023

  1. Use any? to check for warning message and fix brew style

    @abitrolly
    abitrolly committed Sep 26, 2023
    Configuration menu
    Copy the full SHA
    2445b68 View commit details
    Browse the repository at this point in the history

Commits on Sep 27, 2023

  1. Rename fail_with_message to raise_with_message!

    @abitrolly
    abitrolly authored Sep 27, 2023
    Configuration menu
    Copy the full SHA
    10a55ec View commit details
    Browse the repository at this point in the history

  2. Replace refinements with local methods

    @abitrolly
    abitrolly committed Sep 27, 2023
    Configuration menu
    Copy the full SHA
    071a684 View commit details
    Browse the repository at this point in the history

  3. Fix typecheck errors

    @abitrolly
    abitrolly committed Sep 27, 2023
    Configuration menu
    Copy the full SHA
    0c51aea View commit details
    Browse the repository at this point in the history