Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve use of whoami #16059

Merged
merged 1 commit into from
Oct 1, 2023
Merged

Improve use of whoami #16059

merged 1 commit into from
Oct 1, 2023

Conversation

MikeMcQuaid
Copy link
Member

If you're e.g. running Homebrew over sudo: shelling out to whoami is less effective than just telling people which user you're running as when we run the check.

@MikeMcQuaid
Improve use of whoami
39bbc33 
If you're e.g. running Homebrew over `sudo`: shelling out to `whoami`
is less effective than just telling people which user you're running
as when we run the check.
@MikeMcQuaid MikeMcQuaid merged commit a0805d8 into Homebrew:master Oct 1, 2023
31 checks passed
@MikeMcQuaid MikeMcQuaid deleted the whoami branch October 1, 2023 15:04
@buildpulse
Copy link

buildpulse bot commented Oct 1, 2023

Known disruptive tests have failed for this pull request.

Commit SHA: a0805d8
Build URL: https://github.com/Homebrew/brew/actions/runs/6371468757/attempts/1

Suite Name Test Name Details
rspec SystemCommand with both STDOUT and STDERR output from upstream with print_stdout but without print_stderr its result stderr is expected to eq "2\n4\n6\n" →

@buildpulse
Copy link

buildpulse bot commented Oct 1, 2023

Known disruptive tests have failed for this pull request.

Commit SHA: a0805d8
Build URL: https://github.com/Homebrew/brew/actions/runs/6371468757/attempts/1

Suite Name Test Name Details
rspec SystemCommand#run does not format stderr when it starts with \r →

@github-actions github-actions bot added the outdated PR was locked due to age label Nov 1, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@issyl0 issyl0 issyl0 approved these changes

Assignees
No one assigned
Labels
outdated PR was locked due to age
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MikeMcQuaid @issyl0