Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

formulary: load from API for formula renames #16108

Merged
merged 1 commit into from
Oct 12, 2023

Conversation

Bo98
Copy link
Member

@Bo98 Bo98 commented Oct 12, 2023

It was correctly getting the renames from the API, but it was attempting to load the new formula from an installed tap only which will fail for those with Homebrew/core untapped.

Fixes #16107

Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thanks again @Bo98!

@MikeMcQuaid MikeMcQuaid merged commit 41dc533 into Homebrew:master Oct 12, 2023
27 checks passed
@Bo98 Bo98 deleted the api-rename-fix branch October 12, 2023 22:49
@github-actions github-actions bot added the outdated PR was locked due to age label Nov 12, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Formulae redirect in API mode not working correctly.
2 participants