Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dev-cmd/unbottled: add --lost option #16115
dev-cmd/unbottled: add --lost option #16115
Changes from 1 commit
20f00a6
83598bb
e48c155
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Check warning on line 55 in Library/Homebrew/dev-cmd/unbottled.rb
Codecov / codecov/patch
Library/Homebrew/dev-cmd/unbottled.rb#L55
Check warning on line 264 in Library/Homebrew/dev-cmd/unbottled.rb
Codecov / codecov/patch
Library/Homebrew/dev-cmd/unbottled.rb#L262-L264
Check warning on line 266 in Library/Homebrew/dev-cmd/unbottled.rb
Codecov / codecov/patch
Library/Homebrew/dev-cmd/unbottled.rb#L266
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Might be good to not have a copy-paste of common part of the regex with the earlier regex.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure what you mean by this. Are you suggesting adding another variable to hold shared parts of both regexes?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good, handled in e48c155
Check warning on line 271 in Library/Homebrew/dev-cmd/unbottled.rb
Codecov / codecov/patch
Library/Homebrew/dev-cmd/unbottled.rb#L268-L271
Check warning on line 275 in Library/Homebrew/dev-cmd/unbottled.rb
Codecov / codecov/patch
Library/Homebrew/dev-cmd/unbottled.rb#L273-L275
Check warning on line 284 in Library/Homebrew/dev-cmd/unbottled.rb
Codecov / codecov/patch
Library/Homebrew/dev-cmd/unbottled.rb#L282-L284
Check warning on line 306 in Library/Homebrew/dev-cmd/unbottled.rb
Codecov / codecov/patch
Library/Homebrew/dev-cmd/unbottled.rb#L306